Skip to content

Add missing library required by ndr_dev_support:deploy_secrets #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 2 commits into from
Feb 5, 2025
Merged

Add missing library required by ndr_dev_support:deploy_secrets #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b18f613
Add missing library required by ndr_dev_support:deploy_secrets
bshand Feb 5, 2025
52a6a76
Fix concurrent-ruby version to 1.3.4 for older Rails versions
bshand Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [Unreleased]
*no unreleased changes*
### Fixed
* Capistrano: Add missing `tmpdir` requirement to deploy application secrets

## 7.3.1 / 2025-01-02
### Added
Expand Down
3 changes: 3 additions & 0 deletions gemfiles/Gemfile.rails61
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ source 'https://rubygems.org'
gemspec path: '..'

gem 'activesupport', '~> 6.1.0'

# Latest concurrent-ruby breaks Rails < 7.1. See https://github.com/rails/rails/issues/54260
gem 'concurrent-ruby', '1.3.4'
3 changes: 3 additions & 0 deletions gemfiles/Gemfile.rails70
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ source 'https://rubygems.org'
gemspec path: '..'

gem 'activesupport', '~> 7.0.0'

# Latest concurrent-ruby breaks Rails < 7.1. See https://github.com/rails/rails/issues/54260
gem 'concurrent-ruby', '1.3.4'
2 changes: 2 additions & 0 deletions lib/ndr_dev_support/capistrano/deploy_secrets.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require 'tmpdir'

# Add a git or svn secrets respository for ndr_dev_support:deploy_secrets
def add_secrets_repo(name:, url:, scm:, branch: nil)
raise "Invalid repo name #{name}" unless /\A[A-Z0-9_-]+\z/i.match?(name)
Expand Down