Skip to content

tag v7.3.3 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 1 commit into from
Aug 1, 2025
Merged

tag v7.3.3 #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
## [Unreleased]
*no unreleased changes*

## 7.3.3 / 2025-07-31
### Fixed
* Update rubocop version dependency
* rake bundle:update should package gems for all platforms
Expand Down
16 changes: 8 additions & 8 deletions code_safety.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ file safety:
safe_revision: '058996443438979550013c0c983c63b68d3fc58b'
".github/workflows/lint.yml":
comments:
reviewed_by: josh.pencheon
safe_revision: 0ce43640c417e174054f903fd82043948ebe8ccb
reviewed_by: brian.shand
safe_revision: ee3d54ea6bbbdaa73e016c961b1009f1a83dfcd5
".github/workflows/test.yml":
comments:
reviewed_by: brian.shand
safe_revision: 5eb1de9dcb6774acaba4c444b596d293ddbb5ffe
safe_revision: ee3d54ea6bbbdaa73e016c961b1009f1a83dfcd5
".gitignore":
comments:
reviewed_by: josh.pencheon
Expand All @@ -27,7 +27,7 @@ file safety:
CHANGELOG.md:
comments:
reviewed_by: brian.shand
safe_revision: 5eb1de9dcb6774acaba4c444b596d293ddbb5ffe
safe_revision: ee3d54ea6bbbdaa73e016c961b1009f1a83dfcd5
CODE_OF_CONDUCT.md:
comments:
reviewed_by: timgentry
Expand Down Expand Up @@ -247,11 +247,11 @@ file safety:
lib/ndr_dev_support/version.rb:
comments:
reviewed_by: brian.shand
safe_revision: cbdcc0b5ffe24661da57b7989346a5a2269779c7
safe_revision: 6816b09116b8ef4ba1456fdb614705bef5b08c6d
lib/tasks/audit_bundle.rake:
comments:
reviewed_by: kenny.lee
safe_revision: 96f1af81f5aff439742fc293581256317ff4aa46
reviewed_by: brian.shand
safe_revision: ee3d54ea6bbbdaa73e016c961b1009f1a83dfcd5
lib/tasks/audit_code.rake:
comments: Identical to the version reviewed by josh.pencheon when contained within
ndr_support
Expand Down Expand Up @@ -328,7 +328,7 @@ file safety:
ndr_dev_support.gemspec:
comments:
reviewed_by: brian.shand
safe_revision: 71036ef8c1a1d040281c692868246e6ab7a6ba37
safe_revision: ee3d54ea6bbbdaa73e016c961b1009f1a83dfcd5
test/daemon/ci_server_test.rb:
comments:
reviewed_by: josh.pencheon
Expand Down
2 changes: 1 addition & 1 deletion lib/ndr_dev_support/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
# This defines the NdrDevSupport version. If you change it, rebuild and commit the gem.
# Use "rake build" to build the gem, see rake -T for all bundler rake tasks (and our own).
module NdrDevSupport
VERSION = '7.3.2'
VERSION = '7.3.3'
Copy link
Contributor

@ollietulloch ollietulloch Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we happy this is only a patch version change if we're dropping support for Ruby 3.0?

Copy link
Contributor Author

@bshand bshand Aug 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so: Ruby 3.0 is EOL since 2024-04-23, and no longer used by any of our systems. The target version is "currently supported Ruby versions". (I've left in Ruby 3.1 support only because we run Ruby 3.1 regression tests for some projects.)

Copy link
Contributor

@ollietulloch ollietulloch Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think patch versions should be backward compatible, which this change wouldn't be. However, as you say, none of our systems are using 3.0, so agree a patch level bump is fine here.

end