Skip to content

fix link with icon button style #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suezhou merged 2 commits into from
Mar 23, 2025
Merged

fix link with icon button style #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d7ea5e
fix link with icon button style
suezhou Mar 23, 2025
f968e83
rubocop fixes
bshand Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## [Unreleased]
* no unreleased changes
* fix link with icon button style

## 2.4.1 / 2025-02-03
### Fixed
Expand Down
6 changes: 3 additions & 3 deletions app/helpers/ndr_error/errors_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def downstream_fingerprint_link(print)
end

def ticket_link_for(fingerprint, small = false) # rubocop:disable Style/OptionalBooleanParameter
text = "#{bootstrap_icon_tag('asterisk', :bi)} View ticket"
text = bootstrap_icon_tag('asterisk', :bi) + ' View ticket' # rubocop:disable Style/StringConcatenation
css = 'btn btn-outline-secondary'
css << ' btn-xs' if small

Expand All @@ -67,14 +67,14 @@ def ticket_link_for(fingerprint, small = false) # rubocop:disable Style/Optional

def edit_button_for(fingerprint)
css = 'btn btn-outline-secondary'
text = "#{bootstrap_icon_tag('pencil', :bi)} Edit Ticket"
text = bootstrap_icon_tag('pencil', :bi) + ' Edit Ticket' # rubocop:disable Style/StringConcatenation

link_to(text, edit_error_fingerprint_path(fingerprint), class: css)
end

def purge_button_for(fingerprint)
css = 'btn btn-danger'
text = "#{bootstrap_icon_tag('trash-fill', :bi)} Purge"
text = bootstrap_icon_tag('trash-fill', :bi) + ' Purge' # rubocop:disable Style/StringConcatenation

options = {
'method' => :delete,
Expand Down