Skip to content

Fix ruby 3.4 frozen string literal warnings #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 3 commits into from
Nov 7, 2025
Merged

Fix ruby 3.4 frozen string literal warnings #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f91437
GitHub Actions gem installation fix for sass-embedded on ruby 3.1
bshand Nov 5, 2025
5b28b60
Fix ruby 3.4 frozen string literal warnings
bshand Nov 5, 2025
e7ccbf3
Fix ruby 3.4 frozen string literal warnings
bshand Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [Unreleased]
### Fixed
* Support Ruby 3.4, Rails 8.0
* Fix ruby 3.4 frozen string literal warnings

## 2.4.2 / 2025-03-23
* fix link with icon button style
Expand Down
8 changes: 4 additions & 4 deletions app/helpers/ndr_error/errors_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def highlighted_trace_for(error)

error.backtrace.map do |line|
css_classes = 'trace-item'
css_classes << ' stack-only' unless highlighting.include?(line)
css_classes += ' stack-only' unless highlighting.include?(line)

content_tag(:span, line, class: css_classes)
end
Expand Down Expand Up @@ -59,7 +59,7 @@ def downstream_fingerprint_link(print)
def ticket_link_for(fingerprint, small = false) # rubocop:disable Style/OptionalBooleanParameter
text = bootstrap_icon_tag('asterisk', :bi) + ' View ticket' # rubocop:disable Style/StringConcatenation
css = 'btn btn-outline-secondary'
css << ' btn-xs' if small
css += ' btn-xs' if small

url = fingerprint.ticket_url
link_to(text, /^http/i =~ url ? url : "http://#{url}", class: css)
Expand Down Expand Up @@ -87,7 +87,7 @@ def purge_button_for(fingerprint)

def previous_button_for(error)
css = 'btn btn-outline-secondary'
css << ' disabled' if error.nil?
css += ' disabled' if error.nil?
text = bootstrap_icon_tag('chevron-left', :bi)
path = error.nil? ? '#' : error_fingerprint_path(error.error_fingerprint, log_id: error)

Expand All @@ -96,7 +96,7 @@ def previous_button_for(error)

def next_button_for(error)
css = 'btn btn-outline-secondary'
css << ' disabled' if error.nil?
css += ' disabled' if error.nil?
text = bootstrap_icon_tag('chevron-right', :bi)
path = error.nil? ? '#' : error_fingerprint_path(error.error_fingerprint, log_id: error)

Expand Down
7 changes: 7 additions & 0 deletions ndr_error.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ Gem::Specification.new do |s|
# https://bugs.ruby-lang.org/issues/19371
s.add_development_dependency 'psych', '< 5'

# Workaround build issue on GitHub Actions with ruby <= 3.1 when installing sass-embedded
# Versions 1.77.0 and above require ruby >= 3.2 for packaged x86_64-linux binaries
# but say they're compatible with ruby 3.1.
# 1.76.0 has a bug that was fixed in 1.77.1, which we can't use yet.
# https://github.com/sass/dart-sass/issues/2239
s.add_development_dependency 'sass-embedded', '~> 1.75.0' if RUBY_VERSION.start_with?('3.1') # rubocop:disable Gemspec/RubyVersionGlobalsUsage

s.add_development_dependency 'mocha'
s.add_development_dependency 'test-unit', '~> 3.0'

Expand Down