Support Rails 7.1 and 7.2 on ndr_ui version 3.3.2 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshand
force-pushed
the
feature/support_rails_71_72_on_version_3.3
branch
from
1fadac6 to
cabb22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
ndr_ui3.3.xto run on Rails 7.1 and 7.2 without changing jQuery version, by cherry-picking commits from themainbranch.ndr_uiversions >= 4.1.1 already support Rails 7.1 and 7.2, including the current version 5.0.3 (which uses Bootstrap 5).We need this, to enable NDTMS to be upgraded to Rails 7.1 and 7.2 as soon as possible, independent of
ndr_uimajor version (although we should upgrade this soon in https://nhsd-jira.digital.nhs.uk/browse/NDRS4-209).