Skip to content

Restrict treetop gem dependency #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 1 commit into from
Feb 7, 2025
Merged

Restrict treetop gem dependency #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [Unreleased]
* no unreleased changes *
### Fixed
* Restrict treetop gem dependency

## 1.1.2 / 2024-11-18
### Fixed
Expand Down
3 changes: 3 additions & 0 deletions gemfiles/Gemfile.rails70
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ source 'https://rubygems.org'
gemspec path: '..'

gem 'rails', '~> 7.0.0'

# Latest concurrent-ruby breaks Rails < 7.1. See https://github.com/rails/rails/issues/54260
gem 'concurrent-ruby', '1.3.4'
8 changes: 7 additions & 1 deletion tnql.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ lib = File.expand_path('lib', __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'tnql/version'

# We list development dependencies for all Rails versions here.
# Rails version-specific dependencies can go in the relevant Gemfile.
# rubocop:disable Gemspec/DevelopmentDependencies
Gem::Specification.new do |spec|
spec.name = 'tnql'
spec.version = Tnql::VERSION
Expand All @@ -26,7 +29,9 @@ Gem::Specification.new do |spec|
spec.add_dependency 'activesupport', '>= 7.0', '< 8.1'
spec.add_dependency 'chronic', '~> 0.3'
spec.add_dependency 'ndr_support', '>= 3.0', '< 6'
spec.add_dependency 'treetop', '>= 1.4.10'
# treetop 1.6.14 causes errors. I think this may be a buggy release and fixed soon,
# but I'll restrict the version we use for now.
spec.add_dependency 'treetop', '~> 1.6.12', '< 1.6.14'

spec.add_development_dependency 'bundler'
spec.add_development_dependency 'guard'
Expand All @@ -38,3 +43,4 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rake'
spec.add_development_dependency 'terminal-notifier-guard' if RUBY_PLATFORM =~ /darwin/
end
# rubocop:enable Gemspec/DevelopmentDependencies