greenness improvements #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Withouth this, when loading odoo, while a module, installed or not, contains any error, Odoo will simply stop, withouth ginving the least hint or message what is wrong. Nothing will be logged whatsoever. With this fix, not only will a proper error and traceback be logged, but odoo loading will continue, making it possible to work, even if some not installed modules contain errors.
NL66278
force-pushed
the
10.0-developer
branch
from
32d4b0e to
0db0a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first commit makes the logging work (failed before because we tried to pass strings to
'%d'), and the second turns off the check when testing is enabled.We can't use the thread's testing flag here, because this is only set on the thread that runs the unittests themselves. But for testing web stuff, Odoo spins up a second thread to serve the request, and this doesn't have the flag set.
When merging this, please replace my branch with yours again in the buildout.
Now the only things that fail are customer-specific and the webshop test, which I'll check out next week. But please assign somebody who knows the project for looking into the remaining issues.