test(engines): add comprehensive unit and property-based tests for core engines#36
Merged
NP-compete merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
Adds property-based tests (Hypothesis) and fills coverage gaps: - tests/property/test_decay_properties.py: monotonicity, bounds, pinned invariant, rehearsal effect, decay factor properties - tests/property/test_importance_properties.py: bounds, monotonicity, recency decay, source multiplier, explicit override Adds missing unit tests for coverage gaps: - DecayEngine: from_config, apply_rehearsal_in_place, naive datetime, edge cases (threshold estimation, unknown time units) - ImportanceEngine: from_config, naive datetime, invalid metadata, batch/filter default time - RetrievalEngine: from_config, empty after threshold, empty embedding, naive datetime, MMR edge cases Engine coverage: 81% -> 96% (target was >80%) Closes #14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests and property-based tests (Hypothesis) for all core engines, raising engine test coverage from 81% to 96%.
from_config,apply_rehearsal_in_place, naive datetime handling, invalid metadata, edge cases in threshold estimation, and MMR diversityCoverage Improvement
decay.pyimportance.pyretrieval.pyconsolidation.pyworking_memory.py* working_memory was undercounted (test file excluded from prior run)
Files Changed
tests/property/__init__.pytests/property/test_decay_properties.pytests/property/test_importance_properties.pytests/unit/test_decay.pytests/unit/test_importance.pytests/unit/test_retrieval.pyTest plan
from_configclass methods testedCloses #14