SCRIPTS-#644 Rewrite files under scripts/editing/#645
Open
EasonLee2006 wants to merge 12 commits intoNTUEELightDance:mainfrom
Open
SCRIPTS-#644 Rewrite files under scripts/editing/#645EasonLee2006 wants to merge 12 commits intoNTUEELightDance:mainfrom
EasonLee2006 wants to merge 12 commits intoNTUEELightDance:mainfrom
Conversation
…Color.js. also added some tests.
EasonLee2006
force-pushed
the
SCRIPTS-#644
branch
from
c4172b7 to
17741cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
rewrote scripts under the directory scripts/editing/, make sure they got error handling
also added some tests to make sure the scripts work
What type of PR is it?
Refactoring
Todos
make sure the code is compatible with other parts of the repo
What is the Github issue?
#644
How should this be tested?
to test out each script under the directory scripts/editing/, smiply type:
node scripts/editing/<script name>.test.jsit will verify the results of the corresponding script
for example:
under repo root directory, type
node scripts/editing/shiftFrames.test.jsthen it will show the test result of shiftFrames.js