-
Notifications
You must be signed in to change notification settings - Fork 2
Next.js 16 / React 19 へのアップグレード #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TkymHrt
wants to merge
4
commits into
refactor/yama/remove-chakra-ui
Choose a base branch
from
refactor/upgrade-nextjs-16-react-19
base: refactor/yama/remove-chakra-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4c94ab8
refactor: update React imports to include type JSX for better type sa…
TkymHrt 0c11efd
fix: global.cssの不要な呼び出しを修正
TkymHrt 2f25427
refactor: update imports and remove unused notoSansJP font references…
TkymHrt 01034be
fix: NotoSansフォントを再適応(next.js, Issue, #86792)
TkymHrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| import typescriptEslint from '@typescript-eslint/eslint-plugin'; | ||
| import tsParser from '@typescript-eslint/parser'; | ||
| import nextVitals from 'eslint-config-next/core-web-vitals'; | ||
| import eslintPluginBetterTailwindcss from 'eslint-plugin-better-tailwindcss'; | ||
| import _import from 'eslint-plugin-import'; | ||
| import storybook from 'eslint-plugin-storybook'; | ||
| import unusedImports from 'eslint-plugin-unused-imports'; | ||
| import { defineConfig, globalIgnores } from 'eslint/config'; | ||
| import globals from 'globals'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = path.dirname(__filename); | ||
|
|
||
| export default defineConfig([ | ||
| ...nextVitals, | ||
| ...storybook.configs['flat/recommended'], | ||
|
|
||
| { | ||
| extends: [eslintPluginBetterTailwindcss.configs['recommended-warn']], | ||
| settings: { | ||
| 'better-tailwindcss': { | ||
| // Tailwind CSS v4: CSS-based configuration entry file | ||
| entryPoint: 'src/styles/globals.css', | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| globalIgnores([ | ||
| // Default ignores of eslint-config-next | ||
| '.next/**', | ||
| 'out/**', | ||
| 'build/**', | ||
| 'next-env.d.ts', | ||
|
|
||
| // Project specific | ||
| 'src/generated', | ||
| '**/*.config.js', | ||
| '**/*.config.ts', | ||
| ]), | ||
| { | ||
| plugins: { | ||
| '@typescript-eslint': typescriptEslint, | ||
| 'unused-imports': unusedImports, | ||
| import: _import, | ||
| }, | ||
|
|
||
| languageOptions: { | ||
| globals: { | ||
| ...globals.node, | ||
| ...globals.browser, | ||
| }, | ||
|
|
||
| parser: tsParser, | ||
| ecmaVersion: 'latest', | ||
| sourceType: 'module', | ||
|
|
||
| parserOptions: { | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
|
|
||
| project: ['./tsconfig.json', './tsconfig.stories.json'], | ||
| tsconfigRootDir: __dirname, | ||
| }, | ||
| }, | ||
|
|
||
| settings: { | ||
| 'import/resolver': { | ||
| node: { | ||
| extensions: ['.ts', '.tsx'], | ||
| }, | ||
|
|
||
| typescript: {}, | ||
| }, | ||
|
|
||
| react: { | ||
| version: 'detect', | ||
| }, | ||
| }, | ||
|
|
||
| rules: { | ||
| 'unused-imports/no-unused-imports': 'error', | ||
|
|
||
| 'unused-imports/no-unused-vars': [ | ||
| 'warn', | ||
| { | ||
| vars: 'all', | ||
| varsIgnorePattern: '^_', | ||
| args: 'after-used', | ||
| argsIgnorePattern: '^_', | ||
| }, | ||
| ], | ||
|
|
||
| 'import/order': [ | ||
| 'error', | ||
| { | ||
| groups: [ | ||
| 'builtin', | ||
| 'external', | ||
| 'internal', | ||
| ['parent', 'sibling'], | ||
| 'index', | ||
| 'object', | ||
| 'type', | ||
| ], | ||
|
|
||
| 'newlines-between': 'always', | ||
|
|
||
| alphabetize: { | ||
| caseInsensitive: true, | ||
| order: 'asc', | ||
| }, | ||
| }, | ||
| ], | ||
|
|
||
| 'react-hooks/rules-of-hooks': 'error', | ||
| 'react-hooks/exhaustive-deps': 'warn', | ||
|
|
||
| // Next.js (React 19) upgrade can introduce new react-hooks rules that are | ||
| // too noisy for the current codebase. Keep them as warnings for now. | ||
| 'react-hooks/set-state-in-effect': 'warn', | ||
| 'react-hooks/purity': 'warn', | ||
| 'react-hooks/immutability': 'warn', | ||
|
|
||
| // Storybook plugin currently flags existing stories that import | ||
| // '@storybook/react'. Keep as warning until stories are migrated. | ||
| 'storybook/no-renderer-packages': 'warn', | ||
|
|
||
| '@typescript-eslint/no-explicit-any': 'warn', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| }, | ||
| }, | ||
| ]); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| import "./.next/dev/types/routes.d.ts"; | ||
|
|
||
| // NOTE: This file should not be edited | ||
| // see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information. | ||
| // see https://nextjs.org/docs/pages/api-reference/config/typescript for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.