fix: guard SLURM start-time polling behind a feature flag#469
Merged
Conversation
Add `poll_estimated_start_time: bool = True` to `SlurmExecutor` so users who experience issues with the background polling thread introduced in f68f6f2 can opt out by setting the flag to False, while keeping the feature enabled by default for everyone else. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
hemildesai
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poll_estimated_start_time: bool = TruetoSlurmExecutorto expose the polling feature as an opt-out flagschedule()method now checks the flag before starting the background thread introduced in feat: poll and print SLURM job estimated start time while pending #464test_schedule_skips_polling_thread_when_disabled) verifying the thread is not started when the flag isFalseBackground
Commit f68f6f2 introduced a background daemon thread that polls
squeue --startwhile a SLURM job is pending and prints its estimated start time. Some users reported issues with this behaviour. The fix keeps the feature enabled by default but lets affected users disable it viaSlurmExecutor(poll_estimated_start_time=False).Usage
Test plan
🤖 Generated with Claude Code