Add skill and evals for dynamic mode usage#6271
Add skill and evals for dynamic mode usage#6271rostan-t wants to merge 7 commits intoNVIDIA:mainfrom
Conversation
.claude/skills/using-dali-dynamic-mode-workspace/evals/files/pipeline_to_convert.py
Dismissed
Show dismissed
Hide dismissed
.claude/skills/using-dali-dynamic-mode-workspace/evals/files/pipeline_to_convert.py
Dismissed
Show dismissed
Hide dismissed
Greptile SummaryThis PR adds a Claude Code skill ( All significant issues raised in prior review rounds have been addressed:
The skill content itself is accurate: Confidence Score: 5/5Safe to merge — documentation/eval-only change with no production code impact. All previously raised P1-level concerns (missing imports, batch-size variation claim, eval numbering gap, missing max_batch_size guidance) have been resolved in preceding commits. No new correctness, security, or data-integrity issues were found in this diff. Remaining P2-level observations are too trivial to block merge. No files require special attention. Important Files Changed
|
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
e525b96 to
eebd995
Compare
.claude/skills/using-dali-dynamic-mode-workspace/evals/files/pipeline_to_convert.py
Show resolved
Hide resolved
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
.claude/skills/using-dali-dynamic-mode-workspace/evals/evals.json
Outdated
Show resolved
Hide resolved
| mean=[0.485 * 255, 0.456 * 255, 0.406 * 255], | ||
| std=[0.229 * 255, 0.224 * 255, 0.225 * 255], | ||
| ) | ||
| train_step(images.torch(), labels.torch()) |
There was a problem hiding this comment.
Is there a way to test this code against going stale?
There was a problem hiding this comment.
Unless we setup an infrastructure to run the evals in CI, I don't think there is. We should maintain the skill the same way we maintain the documentation.
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Since dynamic mode is fairly new, AI agents are not very good at writing code using it. For instance, according to Anthropic, Claude Sonnet 4.6's knowledge cutoff is August 2026. Even when presented with a few examples, agents miss some dynamic-mode specific patterns and are not very helpful to write code using it.
This PR adds a Claude Code skill containing guidelines on how to use dynamic mode. It was generated with the
/skill-creatorwhich generates evals for the skill. Here are the results on running the eval with Claude Code using Sonnet 4.6:Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A