Skip to content

Update third-party dependencies (2026-03-25)#6277

Open
szalpal wants to merge 2 commits intoNVIDIA:mainfrom
szalpal:deps-update/2026-03-25
Open

Update third-party dependencies (2026-03-25)#6277
szalpal wants to merge 2 commits intoNVIDIA:mainfrom
szalpal:deps-update/2026-03-25

Conversation

@szalpal
Copy link
Copy Markdown
Member

@szalpal szalpal commented Mar 25, 2026

Updated dependencies

  • boost-preprocessor: 1.89.0 → 1.90.0
  • cutlass: 4.4.1 → 4.4.2

Test plan

  • CI passes (lint.yml runs on PRs to main)
  • Python and C++ tests pass

szalpal added 2 commits March 25, 2026 14:07
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 25, 2026

Greptile Summary

This PR bumps two third-party dependencies — CUTLASS (4.4.1 → 4.4.2) and boost-preprocessor (1.89.0 → 1.90.0) — updating both the third_party/README.rst documentation table and the relevant submodule pointer(s). However, the CUTLASS bump is complete and consistent, while the boost-preprocessor bump is documentation-only: the third_party/boost/preprocessor submodule commit was not changed and still points to the same hash as before this PR.

  • third_party/cutlass submodule updated to commit da5e086 (v4.4.2), consistent with the README.
  • third_party/boost/preprocessor submodule still points to cd1b1bd03900b68505822cfa25cb16851bd6caf1 — the same hash as in the base branch — despite the README and PR description claiming a 1.90.0 bump.
  • The missing submodule update means DALI will actually build against boost-preprocessor 1.89.0, not 1.90.0 as advertised.

Confidence Score: 2/5

  • Not safe to merge — the boost-preprocessor submodule was not updated despite the README and PR description claiming a version bump.
  • The CUTLASS update is clean and complete. However, the boost-preprocessor submodule (third_party/boost/preprocessor) points to exactly the same commit on both the base and head branches, meaning the claimed 1.89.0 → 1.90.0 bump did not actually happen. Merging as-is would leave the codebase building against the old version while the documentation claims otherwise, which is misleading and could cause confusion for downstream consumers of DALI.
  • third_party/boost/preprocessor submodule — needs to be pointed to the boost-1.90.0 tag commit.

Important Files Changed

Filename Overview
third_party/README.rst Documents version bumps for boost-preprocessor (1.89.0 → 1.90.0) and cutlass (4.4.1 → 4.4.2), but the boost/preprocessor submodule was not actually updated to match the claimed version.
third_party/cutlass Submodule updated from commit 4370102 (v4.4.1) to da5e086 (v4.4.2), correctly matching the README documentation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    PR["PR #6277\nUpdate third-party deps"]
    PR --> CUTLASS["third_party/cutlass\nsubmodule"]
    PR --> BOOST["third_party/boost/preprocessor\nsubmodule"]
    PR --> README["third_party/README.rst\n(documentation)"]

    CUTLASS -->|"✅ Updated\n4370102 → da5e086\nv4.4.1 → v4.4.2"| C_OK["Consistent with README"]
    BOOST -->|"❌ NOT updated\nstill at cd1b1bd\n(v1.89.0)"| B_ERR["Inconsistent with README"]
    README -->|"Claims v1.90.0"| B_ERR
    README -->|"Claims v4.4.2"| C_OK
Loading

Reviews (1): Last reviewed commit: "Update cutlass to 4.4.2" | Re-trigger Greptile

| `Google Benchmark <https://github.com/google/benchmark>`_ | `1.9.5 <https://github.com/google/benchmark/releases/tag/v1.9.5>`_ | `Apache License 2.0 <https://github.com/google/benchmark/blob/master/LICENSE>`_ |
+------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------+
| `Boost Preprocessor <https://github.com/boostorg/preprocessor>`_ | `1.89.0 <https://github.com/boostorg/preprocessor/releases/tag/boost-1.89.0>`_ | `Boost Software License 1.0 <https://github.com/boostorg/boost/blob/master/LICENSE_1_0.txt>`_ |
| `Boost Preprocessor <https://github.com/boostorg/preprocessor>`_ | `1.90.0 <https://github.com/boostorg/preprocessor/releases/tag/boost-1.90.0>`_ | `Boost Software License 1.0 <https://github.com/boostorg/boost/blob/master/LICENSE_1_0.txt>`_ |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Boost Preprocessor submodule not actually updated

The README documents boost-preprocessor as updated to 1.90.0, and the PR description also claims this bump — but the actual third_party/boost/preprocessor git submodule commit was not changed. Both the base commit (dfc4d8d) and the head commit (f23a987a) point to the same submodule hash: cd1b1bd03900b68505822cfa25cb16851bd6caf1.

By contrast, the third_party/cutlass submodule was correctly updated alongside its README entry.

The boost/preprocessor submodule should be updated to the commit corresponding to the boost-1.90.0 tag before this PR is merged, otherwise the documentation will be misleading about which version is actually in use.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. It seems it was not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants