Skip to content

Fix token dispatched cudagraph_attrs#3625

Open
asolergi-nv wants to merge 2 commits intoNVIDIA:mainfrom
asolergi-nv:fix_cuda_graph_moe
Open

Fix token dispatched cudagraph_attrs#3625
asolergi-nv wants to merge 2 commits intoNVIDIA:mainfrom
asolergi-nv:fix_cuda_graph_moe

Conversation

@asolergi-nv
Copy link
Contributor

What does this PR do ?

When using cuda graphs, some cudagraph_attrs reference attributes from objects of the token dispatcher (e.g. _comm_manager.token_probs) which can't be accessed directly from the top module.

The fix is very simple: Access the attributes one by one (e.g. first _comm_manager, then _comm_manager.token_probs).

It's curious because in another part of the code we do access these attributes correctly.

for i, attr_name in enumerate(valid_cudagraph_attrs):
hier_attr_name = attr_name.split('.')
attr = self.mlp.token_dispatcher
for name in hier_attr_name[:-1]:
attr = getattr(attr, name)
setattr(attr, hier_attr_name[-1], attr_outputs[i])

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@asolergi-nv asolergi-nv requested review from a team as code owners February 26, 2026 16:06
@asolergi-nv asolergi-nv added the Final Review PR is in the "final review" stage label Feb 26, 2026
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team February 26, 2026 16:07
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Feb 26, 2026
@asolergi-nv
Copy link
Contributor Author

/ok to test cef1302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants