Skip to content

Fix upcycling state dict conversion for mixed dense/MoE models#3646

Open
rkteddy wants to merge 1 commit intoNVIDIA:mainfrom
rkteddy:fix/moe-upcycling-mixed-model
Open

Fix upcycling state dict conversion for mixed dense/MoE models#3646
rkteddy wants to merge 1 commit intoNVIDIA:mainfrom
rkteddy:fix/moe-upcycling-mixed-model

Conversation

@rkteddy
Copy link

@rkteddy rkteddy commented Mar 1, 2026

What does this PR do ?

Fix upcycling pipeline for mixed dense/MoE models (i.e., --moe-layer-freq is set with --moe-use-upcycling):

  1. Fix load_kwargs key in training.py: load_checkpoint expects ddp_model but the upcycling path passed model, causing a KeyError.
  2. Fix upcycling_utils.py: in a mixed model, dense layers have no expert parameters, so the converted keys are absent from the MoE state dict. Add an existence check in
    _convert_key_value and _expand_key_value to skip such keys.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@rkteddy rkteddy requested review from a team as code owners March 1, 2026 05:23
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 1, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 1, 2026 05:23
@yaox12 yaox12 added the Expert Review Apply this label to indicate that your PR is ready for expert review. label Mar 2, 2026
Copy link
Contributor

@yanring yanring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants