[None][infra] fix slurm results path #8751

yuanjingx87 · 2025-10-29T04:57:08Z

Summary by CodeRabbit

Bug Fixes
- Corrected test results retrieval path in the submission process.
- Updated job initialization workflow to execute setup tasks unconditionally across all nodes.

Description

Currently the result.xml is not uploaded properly, fixed it by update the result path

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>

coderabbitai · 2025-10-29T05:00:24Z

📝 Walkthrough

Walkthrough

The changes modify Jenkins build pipeline configuration to adjust the path for retrieving test results XML and remove local SLURM rank gating from initialization script, allowing previously head-node-only operations to execute unconditionally.

Changes

Cohort / File(s)	Summary
Test Pipeline Configuration `jenkins/L0_Test.groovy`	Changed remote results XML path from `/home/svc_tensorrt/bloom/scripts/${nodeName}/results/results.xml` to `/home/svc_tensorrt/bloom/scripts/${nodeName}/results.xml` to retrieve file from updated location.
SLURM Execution Script `jenkins/scripts/slurm_run.sh`	Removed `resultsPath` variable creation and eliminated `SLURM_LOCALID==0` conditional gating, making setup operations (job ID logging, asset download/extraction, system checks, environment setup) execute unconditionally on all ranks instead of only on head node.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

SLURM_LOCALID gating removal: Verify that unconditional execution of previously head-node-only operations (asset download, job ID logging, environment setup) does not introduce race conditions or redundant work across distributed ranks.
Path change correctness: Confirm the XML path change accurately reflects the new results file location and that downstream consumers (L0_Test.groovy) expect this modified path.
resultsPath removal impact: Validate that removal of the resultsPath variable does not break dependent logic or downstream references within the script.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Description Check	⚠️ Warning	The pull request description is largely incomplete and does not adequately meet the template requirements. The Description section provides only a minimal, vague explanation ("Currently the result.xml is not uploaded properly, fixed it by update the result path") without clearly detailing what the issue was or why the specific path changes resolve it. The Test Coverage section is entirely empty with no tests listed. The PR Checklist section is insufficiently completed—only the final checkbox is marked, while the substantive checklist items (PR description clarity, coding guidelines compliance, test cases, dependency scanning, CODEOWNERS updates, documentation, and reviewer appropriateness) are left unchecked and unreviewed.	The author must complete the missing sections before this PR can be merged. Specifically, expand the Description section to clearly explain the issue, the root cause, and why the path change from `/home/svc_tensorrt/bloom/scripts/${nodeName}/results/results.xml` to `/home/svc_tensorrt/bloom/scripts/${nodeName}/results.xml` resolves it. Provide a comprehensive list of relevant tests in the Test Coverage section that validate the results XML upload functionality. Complete the individual checklist items by reviewing and checking the appropriate boxes, not just the final checkbox.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[None][infra] fix slurm results path" directly addresses the primary change in the changeset—fixing the SLURM results path to enable proper upload of result.xml files. The title follows the repository's required format template correctly, is concise and specific, and clearly communicates the main intent of the pull request without being vague or generic.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

yuanjingx87 · 2025-10-29T05:01:50Z