Skip to content

Conversation

@ZhanruiSunCh
Copy link
Collaborator

@ZhanruiSunCh ZhanruiSunCh commented Oct 29, 2025

Summary by CodeRabbit

  • Chores
    • Enhanced pod scheduling constraints for performance testing environments. When performance mode is active with single GPU configurations, pods now include additional scheduling labels to optimize resource allocation and placement.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@ZhanruiSunCh ZhanruiSunCh requested review from a team as code owners October 29, 2025 06:04
@ZhanruiSunCh ZhanruiSunCh requested review from kxdc and poweiw October 29, 2025 06:04
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --stage-list "H100_PCIe-TensorRT-Perf-1, H100_PCIe-PyTorch-Perf-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

📝 Walkthrough

Walkthrough

A new label tensorrt/test_type: perf is added to Kubernetes pod selectors in performance mode testing when single GPUs are configured. This enhances pod scheduling constraints without modifying control flow or error handling logic.

Changes

Cohort / File(s) Summary
Pod selector configuration enhancement
jenkins/L0_Test.groovy
Added tensorrt/test_type: perf label to pod selectors in createKubernetesPodConfig when perfMode is enabled and multiple GPUs are not present, enabling more granular pod scheduling control.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single file modification with isolated, straightforward label addition
  • No control flow or error handling changes
  • Verify the label is correctly applied only when both conditions are met (perfMode true AND single GPU)

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description consists entirely of the template structure with empty content sections. The "Description" section (which should explain the issue and solution), the "Test Coverage" section (which should list relevant tests), and the PR Checklist items have not been filled in with any substantive information. While the author did check the final checklist box, the required sections explaining what is being changed and why, along with test coverage details, remain blank. This leaves reviewers without the context needed to understand the motivation and validation for the infrastructure change.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title follows the required template format with a valid JIRA ticket [TRTLLM-8930], a lowercase type [infra], and a clear summary. The title accurately reflects the main change described in the raw summary: adding the tensorrt/test_type: perf Kubernetes label to pod selectors in performance-mode test stages. The title is specific, concise, and clearly communicates the primary purpose of the changeset to someone reviewing the commit history.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00eaf5f and da7de12.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/L0_Test.groovy (1)

1298-1307: Verify that infrastructure has nodes labeled with tensorrt/test_type: perf before merging.

The code change itself is sound—the conditional logic correctly targets single-GPU performance tests and the node selector syntax is valid. However, this change assumes that nodes in the TensorRT Blossom pool have already been labeled with tensorrt/test_type: perf. If those nodes lack this label, performance test pods will fail to schedule with no fallback mechanism.

Before merging, coordinate with your infrastructure team to confirm:

  • H100/A100 single-GPU machines in the Blossom pool have the tensorrt/test_type: perf label applied
  • The label rollout is complete before performance test stages are deployed with this code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22856 [ run ] triggered by Bot. Commit: da7de12

@ZhanruiSunCh ZhanruiSunCh requested a review from chzblych October 29, 2025 09:23
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22856 [ run ] completed with state SUCCESS. Commit: da7de12
/LLM/main/L0_MergeRequest_PR pipeline #17238 (Partly Tested) completed with status: 'FAILURE'

…test_type: perf' in the K8S template

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com>
@ZhanruiSunCh ZhanruiSunCh force-pushed the user/zhanruis/1029_jira_8930 branch from b208b8a to bd5f731 Compare October 30, 2025 10:10
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --stage-list "H100_PCIe-TensorRT-Perf-1, H100_PCIe-PyTorch-Perf-1"

@ZhanruiSunCh ZhanruiSunCh enabled auto-merge (squash) October 30, 2025 10:11
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23034 [ run ] triggered by Bot. Commit: bd5f731

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23034 [ run ] completed with state SUCCESS. Commit: bd5f731
/LLM/main/L0_MergeRequest_PR pipeline #17368 (Partly Tested) completed with status: 'SUCCESS'

@ZhanruiSunCh
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23050 [ reuse-pipeline ] triggered by Bot. Commit: bd5f731

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23050 [ reuse-pipeline ] completed with state SUCCESS. Commit: bd5f731
Reusing PR_Github #23034 (Partly Tested) for commit bd5f731

@ZhanruiSunCh ZhanruiSunCh merged commit 547d799 into NVIDIA:main Oct 30, 2025
5 checks passed
fredricz-20070104 pushed a commit to fredricz-20070104/TensorRT-LLM that referenced this pull request Nov 5, 2025
…test_type: perf' in the K8S template (NVIDIA#8752)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants