Merged
Conversation
Contributor
Greptile SummaryThis PR aligns both Key observations:
|
| Filename | Overview |
|---|---|
| earth2studio/models/px/graphcast_operational.py | Updated _input_coords and _output_coords lat from ascending [-90, 90] to descending [90, -90], and added out.flip(-2) in iterator_result_to_tensor to convert JAX's native ascending output back to descending order. Logic is correct — the pre-existing reindex(lat=sorted(...)) in from_dataarray_to_dataset already handles the ascending-to-descending conversion for JAX inputs. |
| earth2studio/models/px/graphcast_small.py | Same lat coordinate direction fix as graphcast_operational.py: _input_coords/_output_coords now use [90, -90] and iterator_result_to_tensor applies out.flip(-2). Minor docstring improvement removing "south-pole including" in favour of "pole including". |
| CHANGELOG.md | Added a changelog entry under the "Changed" section noting the updated GraphCast latitude convention. Clear and accurate. |
Last reviewed commit: 28e6c0c
Collaborator
Author
|
/blossom-ci |
NickGeneva
commented
Mar 11, 2026
Collaborator
Author
|
/blossom-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earth2Studio Pull Request
Description
Closes: #710
Validated with
Code
Main

New

Checklist
Dependencies