Open
Conversation
When the write pointer moves to write a new record, it takes care not to straddle erase blocks; when reading back account for this. Fix a memory leak in the NvVarIntLibrary. Bug 4788402 Change-Id: I5ff718c066860ca9f20a7bfa4a006b57405f1911 Signed-off-by: Girish Mahadevan <gmahadevan@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/tegra/bootloader/uefi/edk2-nvidia/+/3244202 Reviewed-by: svcacv <svcacv@nvidia.com> Reviewed-by: Ashish Singhal <ashishsingha@nvidia.com> GVS: buildbot_gerritrpt <buildbot_gerritrpt@nvidia.com> Reviewed-by: svc-sw-mobile-l4t <svc-sw-mobile-l4t@nvidia.com>
gmahadevan
force-pushed
the
varint-readfix
branch
from
b0847a5 to
8d0b58c
Compare
When figuring out the LBA for the current block we accidentally used the partition offset and not the block size. Change-Id: I9d0cb3f38694663b832a3d34bd8dbcf9d73096f2 Signed-off-by: Girish Mahadevan <gmahadevan@nvidia.com>
gmahadevan
force-pushed
the
varint-readfix
branch
from
8d0b58c to
9d0ad7f
Compare
simbahiker
approved these changes
Feb 18, 2025
I don't think so as both #103 and #118 target jetpack 6 branches while this PR targets jetpack 5. There is the sibling of this PR: #113 that target jetpack 6 that might have been superseeded. Really unclear whether this has been fixed on jp5, seems still present on BSP 35.6.2 as it looks really as an issue we just had. BSP 35.6.3 still not yet released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to the Variable Store Integrity feature. The fixes are to the way the code handles traversing blocks in the Flash device.
The fixes address boot failures with this crash signature:
ASSERT [FvbNorFlashStandaloneMm] /out/nvidia/optee_ftpm.t234-uefi/StandaloneMmOptee_RELEASE/edk2-nvidia/Silicon/NVIDIA/Drivers/FvbNorFlashDxe/FvbNorFlashStandaloneMm.c(937): ((BOOLEAN)(0==1))