fix: remove duplicate status:2 attempt writes in TreeSearchProbe#1655
Open
Christbowel wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: remove duplicate status:2 attempt writes in TreeSearchProbe#1655Christbowel wants to merge 1 commit intoNVIDIA:mainfrom
Christbowel wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
TreeSearchProbe.probe() was writing each attempt to the report file after running the detector internally. The harness also writes the same attempt after probe.probe() returns, resulting in every attempt appearing once as status:1 and twice as status:2 in the report. Remove the redundant write from TreeSearchProbe — the harness already handles status:2 reporting correctly for all probe types. Fixes NVIDIA#1522 Signed-off-by: christbowel <0xdeadbeef@christbowel.com>
jmartin-tech
approved these changes
Apr 3, 2026
Collaborator
jmartin-tech
left a comment
There was a problem hiding this comment.
Thanks, this makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
TreeSearchProbe.probe()was calling the detector internally and thenwriting each attempt directly to the report file as
status:2. The harness(
harnesses/base.py) independently writes the same attempts asstatus:2after
probe.probe()returns — this is the standard flow for all probe types.The result: every attempt produced by
TreeSearchProbeappeared once asstatus:1and twice asstatus:2in the report, with identical UUIDsand content. Verified on
topic.WordnetControversialwhich showed 56/56UUIDs affected.
The fix removes the 4 redundant lines from
TreeSearchProbe.probe().The detector call is kept,
TreeSearchProbeneeds the detector resultsinternally to make tree-search decisions (continue exploring or not).
Only the write is removed.
Fixes #1522
Verification
All probes inheriting from
TreeSearchProbeare affected:topic.WordnetControversial,topic.WordnetBlockedWords,topic.WordnetAllowedWords.