Allow pip install to take arguments that come after 'install'#530
Merged
samcmill merged 1 commit intoNVIDIA:masterfrom Dec 19, 2025
Merged
Allow pip install to take arguments that come after 'install'#530samcmill merged 1 commit intoNVIDIA:masterfrom
samcmill merged 1 commit intoNVIDIA:masterfrom
Conversation
2 tasks
samcmill
reviewed
Dec 19, 2025
Collaborator
|
Can you please resolve the merge conflicts? |
Signed-off-by: Dylan Eustice <deustice@nvidia.com> Replace index_url with more general install_args There could be other arguments that need to be passed to 'pip install' that must come *after* the install. Include all of them. Signed-off-by: Dylan Eustice <deustice@nvidia.com> Add unit test for pip install args Signed-off-by: Dylan Eustice <deustice@nvidia.com> Update docs Switch unit test to single arg Signed-off-by: Dylan Eustice <deustice@nvidia.com>
dylan-eustice
force-pushed
the
pip-install-args
branch
from
8835371 to
3bc653e
Compare
Contributor
Author
Should be done now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Some arguments, e.g.
--index-url, must come after theinstallpart of a pip install. Currently, theargskwarg puts arguments prior toinstall. This allows for general installation arguments to be passed.Author Checklist
pydocmd generate) if any docstrings have been modified