Enable NodeFeature API by default in GFD #1504
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
rajathagasthya
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
tariq1890
elezar
reviewed
Nov 18, 2025
| nfd: | ||
| nameOverride: node-feature-discovery | ||
| enableNodeFeatureApi: false | ||
| enableNodeFeatureApi: true |
Member
There was a problem hiding this comment.
Does the behaviour differ between upgrades and new installations due to this toggle?
Contributor
Author
There was a problem hiding this comment.
It should automatically upgrade to using NFD when a new chart and device plugin image is used, so I don't think the behavior differs. Is there a particular scenario you were thinking of?
Contributor
There was a problem hiding this comment.
I believe the answer is yes, but just to confirm -- if we upgrade the device-plugin helm chart, does the NFD subchart also get upgraded and the value of this field, enableNodeFeatureApi, gets toggled from false to true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification steps:
NodeFeatureCR is created./etc/kubernetes/node-feature-discovery/features.d/.