Modify pipeline for including global_params, updates to add workflow for HLPW data, modify metadata to include physics_constants in form of dictionary#40
Merged
saikrishnanc-nv merged 28 commits intoNVIDIA:mainfrom Dec 15, 2025
Conversation
examples/external_aerodynamics/External_Aero_Data_Processing_Reference.md
Show resolved
Hide resolved
examples/external_aerodynamics/External_Aero_Data_Processing_Reference.md
Show resolved
Hide resolved
examples/external_aerodynamics/external_aero_global_params_data_processors.py
Outdated
Show resolved
Hide resolved
examples/external_aerodynamics/external_aero_surface_data_processors.py
Outdated
Show resolved
Hide resolved
Contributor
|
@ns5678 One main thing I'd ask for in the PR - Can you please add tests? You can look at https://github.com/NVIDIA/physicsnemo-curator/tree/main/tests/test_examples/test_external_aerodynamics for examples. |
saikrishnanc-nv
suggested changes
Nov 26, 2025
examples/external_aerodynamics/config/external_aero_etl_drivaerml.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheel N. <snidhan@nvidia.com>
ns5678
changed the title
global_params, updates to add workflow for HLPW data, modify metadata to include physics_constants in form of dictionary
examples/external_aerodynamics/config/external_aero_etl_hlpw.yaml
Outdated
Show resolved
Hide resolved
examples/external_aerodynamics/config/external_aero_etl_hlpw.yaml
Outdated
Show resolved
Hide resolved
examples/external_aerodynamics/external_aero_global_params_data_processors.py
Show resolved
Hide resolved
examples/external_aerodynamics/external_aero_surface_data_processors.py
Outdated
Show resolved
Hide resolved
examples/external_aerodynamics/external_aero_surface_data_processors.py
Outdated
Show resolved
Hide resolved
tests/test_examples/test_external_aerodynamics/test_data_transformations.py
Show resolved
Hide resolved
tests/test_examples/test_external_aerodynamics/test_data_transformations.py
Show resolved
Hide resolved
saikrishnanc-nv
previously approved these changes
Dec 15, 2025
Contributor
|
/blossom-ci |
1 similar comment
Contributor
|
/blossom-ci |
Contributor
|
/blossom-ci |
saikrishnanc-nv
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global_parametersis added as a distinct transformationglobal_parametersis propagated to AhmedML and DrivAerML configurationsglobal_parametersprocessing is tested for that datasetphysics_constantsin the metadata is converted to a dictionary rather than being hard-coded tostream_velocityandair_densityexternal_aero_volume_data_processors.pyandexternal_aero_surface_data_processors.pyfor ingesting HLPW data