-
Notifications
You must be signed in to change notification settings - Fork 15
Modify pipeline for including global_params, updates to add workflow for HLPW data, modify metadata to include physics_constants in form of dictionary
#40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c9286eb
(feat) Add data preprocessing pipeline for HLPW
f251b34
(chore) Fix errors in the pipeline
d65adcb
(feat) Pipeline for global params addition similar to volume/surface…
073c19f
Merge branch 'NVIDIA:main' into sn/hlpw-data
ns5678 6b70451
(chore) fix error and clean implementation
a72d1ad
(chore) clean code for PR
ns5678 88362dc
(chore) refactor constants.py and its propagation through config
ns5678 fe19370
(chore) remove VSCode settings file
ns5678 d380280
(chore) update external aerodynamics data processing and logging
ns5678 197220e
Merge branch 'main' into sn/hlpw-data
ns5678 6e6712a
(chore) set data_processors inputs to previous state
ns5678 34a21b8
Merge branch 'sn/hlpw-data' of https://github.com/ns5678/physicsnemo-…
ns5678 2eb368a
(chore) remove whitespace
ns5678 5751d6b
(chore) refactor drivaerml and hlpw yaml files to comply with new loc…
ns5678 ea52c3a
(chore) further clean up drivaerml yaml
ns5678 240dd21
(chore) minor comment fix
ns5678 552da5b
(chore) update imports in data processors
ns5678 437dc88
(chore) fix import in data_transformations
ns5678 1a0619e
(feat) improve metadata processing and global_params processing
ns5678 2f5746b
(chore) improve global_params extraction and handling
ns5678 0c8cd9c
(chore) reformat comments and logs
ns5678 d403a48
(chore) fix some more tests
ns5678 f8b517b
(chore) black formatting
ns5678 8ea75aa
Merge branch 'main' into sn/hlpw-data
ns5678 23a0cc5
(chore) address PR comments
ns5678 6dec34e
(chore) update PR
ns5678 c79eb9b
(chore) fix blossom error
ns5678 b5fe9da
Merge branch 'main' into sn/hlpw-data
ns5678 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,4 @@ | |
| .coverage* | ||
| .pytest_cache* | ||
| .ruff_cache* | ||
| .vscode/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
examples/external_aerodynamics/config/external_aero_etl_hlpw.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-FileCopyrightText: All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| defaults: | ||
| - /external_aero_etl_drivaerml | ||
| - override /variables/surface: hlpw | ||
| - override /variables/volume: hlpw | ||
| - override /variables/global: hlpw | ||
| - _self_ | ||
|
|
||
| etl: | ||
| common: | ||
| kind: hlpw | ||
| model_type: surface # produce data for which model? surface, volume, combined | ||
|
|
||
| processing: | ||
| num_processes: 12 | ||
|
|
||
| transformations: | ||
| surface_preprocessing: | ||
| # Use HLPW-specific transformation that handles N_BF field | ||
| _target_: data_transformations.ExternalAerodynamicsSurfaceTransformationHLPW | ||
| _convert_: all | ||
| nbf_field_name: "N_BF" | ||
|
|
||
| surface_processors: | ||
| - _target_: external_aero_surface_data_processors.decimate_mesh | ||
| _partial_: true | ||
| algo: decimate_pro | ||
| reduction: 0.0 | ||
| preserve_topology: false | ||
|
|
||
| # Note: normalize_surface_normals not needed - already done via N_BF normalization | ||
|
|
||
| # HLPW-specific non-dimensionalization | ||
| - _target_: external_aero_surface_data_processors.non_dimensionalize_surface_fields_hlpw | ||
| _partial_: true | ||
| pref: 176.352 | ||
| tref: 518.67 | ||
| - _target_: external_aero_surface_data_processors.update_surface_data_to_float32 | ||
| _partial_: true | ||
|
|
||
| volume_preprocessing: | ||
| _target_: data_transformations.ExternalAerodynamicsVolumeTransformation | ||
| _convert_: all | ||
| volume_processors: | ||
| - _target_: external_aero_volume_data_processors.non_dimensionalize_volume_fields_hlpw | ||
| _partial_: true | ||
| pref: 176.352 | ||
| tref: 518.67 | ||
| uref: 2679.505 | ||
| - _target_: external_aero_volume_data_processors.update_volume_data_to_float32 | ||
| _partial_: true | ||
| - _target_: external_aero_volume_data_processors.shuffle_volume_data | ||
| _partial_: true | ||
|
|
||
| global_params_preprocessing: | ||
| _target_: data_transformations.ExternalAerodynamicsGlobalParamsTransformation | ||
| _convert_: all | ||
| global_parameters: ${etl.global_parameters} | ||
| global_params_processors: | ||
| - _target_: external_aero_global_params_data_processors.process_global_params_hlpw | ||
| _partial_: true |
27 changes: 27 additions & 0 deletions
27
examples/external_aerodynamics/config/variables/global/ahmedml.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # @package etl | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-FileCopyrightText: All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| global_parameters: | ||
| inlet_velocity: | ||
| type: vector | ||
| reference: [30.0] # Inlet velocity vector in m/s, if a 2D vector, give [30, 30], if a 3D vector give [30, 30, 30] | ||
| air_density: | ||
| type: scalar | ||
| reference: 1.205 # Air density in kg/m³ | ||
| pressure: | ||
| type: scalar | ||
| reference: 101325.0 # Reference pressure in Pa |
27 changes: 27 additions & 0 deletions
27
examples/external_aerodynamics/config/variables/global/drivaerml.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # @package etl | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-FileCopyrightText: All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| global_parameters: | ||
| inlet_velocity: | ||
| type: vector | ||
| reference: [30.0] # Inlet velocity vector in m/s, if a 2D vector, give [30, 30], if a 3D vector give [30, 30, 30] | ||
| air_density: | ||
| type: scalar | ||
| reference: 1.205 # Air density in kg/m³ | ||
| pressure: | ||
| type: scalar | ||
| reference: 101325.0 # Reference pressure in Pa |
21 changes: 21 additions & 0 deletions
21
examples/external_aerodynamics/config/variables/global/hlpw.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # @package etl | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-FileCopyrightText: All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| global_parameters: | ||
| AoA: | ||
| type: scalar | ||
| reference: 22.0 # Angle of Attack in degrees |
23 changes: 23 additions & 0 deletions
23
examples/external_aerodynamics/config/variables/surface/hlpw.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # @package etl.transformations.surface_preprocessing | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-FileCopyrightText: All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| surface_variables: | ||
| PROJ(AVG(T)): scalar | ||
| PROJ(AVG(P)): scalar | ||
| AVG(TAU_WALL(0)): scalar | ||
| AVG(TAU_WALL(1)): scalar | ||
| AVG(TAU_WALL(2)): scalar |
21 changes: 21 additions & 0 deletions
21
examples/external_aerodynamics/config/variables/volume/hlpw.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # @package etl.transformations.volume_preprocessing | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-FileCopyrightText: All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| volume_variables: | ||
| avg(P): scalar | ||
| avg(T): scalar | ||
| avg(u): vector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.