Skip to content

Fixed dimension of frequency threshold in 2d#3

Open
scaomath wants to merge 1 commit intoNVlabs:masterfrom
scaomath:test
Open

Fixed dimension of frequency threshold in 2d#3
scaomath wants to merge 1 commit intoNVlabs:masterfrom
scaomath:test

Conversation

@scaomath
Copy link
Copy Markdown

@scaomath scaomath commented Nov 7, 2022

Based on the paper's Figure 3: https://openreview.net/pdf?id=EXHG-A3jlM

I think the number of modes threshold in 2d

total_modes = N // 2 + 1
kept_modes = int(total_modes * self.hard_thresholding_fraction)

should be W instead of N since N = H*W, similar applies to bfno2d.py.

Nice paper btw. @jtguibas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant