Conversation
|
noticed there are two patterns import {Ionicons} from '@expo/vector-icons';import Ionicons from '@expo/vector-icons/Ionicons';any specific reason for that? I saw lets standardize to one way to import if we can! |
Not a specific reason. I think it just kinda slipped but I agree! |
yuliadub
left a comment
There was a problem hiding this comment.
thanks for pushing this out - im excited to get this merged in sooner then later! a few comments but otherwise looks good to me!
Sounds good! I'll wait until 1.0.17 is released everywhere to push it out, but I'll get it in Preview once it's merged |
aacd389 to
4b632a3
Compare
For this we should be using the Default import and not the Named import for better performance which is recommended by the Expo docs |
This unifies the icons we're using in the app as we were pulling in icons from 8 different icon sets. I decided to go with Ionicons because it seemed to have all of the icons that we needed and it looked the best (in my opinion).
I tested on both Android and iOS, and adjusted icon sizes to try to match the original sizes as best as possible.
I used this website to find the Ionicon equivalent from the other icon sets.
https://icons.expo.fyi/Index