Skip to content

Use 1 Icon Set#1103

Merged
kevinherdez merged 3 commits intoNWACus:mainfrom
kevinherdez:kevinherdez/pick1IconSet
Mar 16, 2026
Merged

Use 1 Icon Set#1103
kevinherdez merged 3 commits intoNWACus:mainfrom
kevinherdez:kevinherdez/pick1IconSet

Conversation

@kevinherdez
Copy link
Copy Markdown
Collaborator

This unifies the icons we're using in the app as we were pulling in icons from 8 different icon sets. I decided to go with Ionicons because it seemed to have all of the icons that we needed and it looked the best (in my opinion).

I tested on both Android and iOS, and adjusted icon sizes to try to match the original sizes as best as possible.

I used this website to find the Ionicon equivalent from the other icon sets.
https://icons.expo.fyi/Index

@yuliadub
Copy link
Copy Markdown
Collaborator

noticed there are two patterns

import {Ionicons} from '@expo/vector-icons';
import Ionicons from '@expo/vector-icons/Ionicons';

any specific reason for that? I saw lets standardize to one way to import if we can!

@kevinherdez
Copy link
Copy Markdown
Collaborator Author

noticed there are two patterns

import {Ionicons} from '@expo/vector-icons';
import Ionicons from '@expo/vector-icons/Ionicons';

any specific reason for that? I saw lets standardize to one way to import if we can!

Not a specific reason. I think it just kinda slipped but I agree!

Copy link
Copy Markdown
Collaborator

@yuliadub yuliadub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pushing this out - im excited to get this merged in sooner then later! a few comments but otherwise looks good to me!

@kevinherdez
Copy link
Copy Markdown
Collaborator Author

thanks for pushing this out - im excited to get this merged in sooner then later! a few comments but otherwise looks good to me!

Sounds good! I'll wait until 1.0.17 is released everywhere to push it out, but I'll get it in Preview once it's merged

@kevinherdez kevinherdez force-pushed the kevinherdez/pick1IconSet branch from aacd389 to 4b632a3 Compare March 16, 2026 20:29
@kevinherdez
Copy link
Copy Markdown
Collaborator Author

noticed there are two patterns

import {Ionicons} from '@expo/vector-icons';
import Ionicons from '@expo/vector-icons/Ionicons';

any specific reason for that? I saw lets standardize to one way to import if we can!

Not a specific reason. I think it just kinda slipped but I agree!

For this we should be using the Default import and not the Named import for better performance which is recommended by the Expo docs

@kevinherdez kevinherdez added this pull request to the merge queue Mar 16, 2026
Merged via the queue into NWACus:main with commit f2a4424 Mar 16, 2026
5 checks passed
@kevinherdez kevinherdez deleted the kevinherdez/pick1IconSet branch March 16, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants