Fix forecast query key bug#1164
Merged
stevekuznetsov merged 2 commits intoNWACus:mainfrom Apr 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not correctly calculate the
nominalDatethat we attach to the query key for theuseAvalancheForecastcall. The issue was that we were incorrectly assuming that theexpires_timefield returned in the avalanche center metadata was an integer. However, there are at least 3 centers that return a float to specify that the forecasts expired on the half hour. For example, NWAC's expires time is18.5.We were creating a timestamp using the time passed in as the hour so the expires time for
18.5was18.5:00:00instead of18:30:00. The invalid time was being changed to00:00:00and leading to an incorrect nominal date becauserequestedTimewas guaranteed to be beforeexpiresTime.I created a helper function that correctly creates the string and added tests