Fix deep linking config based on stack changes#1165
Open
kevinherdez wants to merge 1 commit intoNWACus:kevinherdez/mapProjectfrom
Open
Fix deep linking config based on stack changes#1165kevinherdez wants to merge 1 commit intoNWACus:kevinherdez/mapProjectfrom
kevinherdez wants to merge 1 commit intoNWACus:kevinherdez/mapProjectfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
linking configfor the new stack and introducesObservationDetailViewModal.The reason for the addition is that we want to show the
ObservationDetailViewfrom a modal instead of pushing it onto the stack. I decided to break this out into a separate view because the header that we show depending on if we're showing the modal or showing the stack is different, and I didn't want to overloadNavigationStackHeaderfor this one use case.