Feature/266747 nof bootstrapping performance#146
Open
danhaywood wants to merge 4 commits intoNakedObjectsGroup:7.0from
Open
Feature/266747 nof bootstrapping performance#146danhaywood wants to merge 4 commits intoNakedObjectsGroup:7.0from
danhaywood wants to merge 4 commits intoNakedObjectsGroup:7.0from
Conversation
Branch: feature/266747-nof-bootstrapping-performance
Branch: feature/266747-nof-bootstrapping-performance
…nMode and SortingPolicy instead of one boolean and be set differently and also method overloading to make it explicit and preserve binary compatibiliy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm creating this not for you to apply (necessarily), but so that you can see the customisations that we've applied.
These were based off 7.0.14 (81873af) but I couldn't find a way in the github UI to create a PR with that as the base commit, so I used 7.0 as the base branch.
Also, in the github UI it shows lots of changes to Introspector.cs. However, they are mostly whitespace changes. Funnily enough using TFS' UI, it shows only a small number of changes. Perhaps a different tool such as SourceTree would do a better job of highlighting the differences. To describe the change: it's just to pass the SortingPolicy enum in to skip sorting of methods (since this is a UI concern, not required for integ tests).