Skip to content

Increment array support #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
partydragen wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Increment array support #3579

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de42dc4
Increment array support
partydragen Jan 30, 2025
4442240
Remove decrement fields type
partydragen Jan 30, 2025
6ce2b46
Merge branch 'develop' into increment-array-support
partydragen Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 48 additions & 14 deletions core/classes/Database/DB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,33 +386,67 @@ public function update(string $table, $where, array $fields): bool
}

/**
* Increment a numeric column value by 1.
* Increment a numeric column value by 1 or array of data in "column => value" format to increment.
*
* @param string $table The table to use.
* @param int $id The id of the row to increment a column in.
* @param string $field The field to increment.
* @return bool Whether an error occurred or not.
* @param string $table The table to use.
* @param int $id The id of the row to increment a column in.
* @param string|array $fields Array of data to in "column => value" format to increment.
Copy link
Member

@samerton samerton Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, if $fields is in the format ['column_one', 'column_two'], then we could default the value to 1?

* @return bool Whether an error occurred or not.
*/
public function increment(string $table, int $id, string $field): bool
public function increment(string $table, int $id, $fields): bool
{
$table = $this->_prefix . $table;

return !$this->query("UPDATE {$table} SET {$field} = {$field} + 1 WHERE id = ?", [$id])->error();
if (!is_array($fields)) {
return !$this->query("UPDATE {$table} SET {$fields} = {$fields} + 1 WHERE id = ?", [$id])->error();
} else {
$set = '';
$x = 1;

foreach (array_keys($fields) as $column) {
$set .= "`{$column}` = `{$column}` + ?";
if ($x < count($fields)) {
$set .= ', ';
}
$x++;
}
}

$sql = "UPDATE {$table} SET {$set} WHERE id = ?";

return !$this->query($sql, array_merge($fields, [$id]))->error();
}

/**
* Decrement a numeric column value by 1.
* Decrement a numeric column value by 1 or array of data in "column => value" format to decrement.
*
* @param string $table The table to use.
* @param int $id The id of the row to decrement a column in.
* @param string $field The field to increment.
* @return bool Whether an error occurred or not.
* @param string $table The table to use.
* @param int $id The id of the row to decrement a column in.
* @param string|array $fields Array of data to in "column => value" format to decrement.
* @return bool Whether an error occurred or not.
*/
public function decrement(string $table, int $id, string $field): bool
public function decrement(string $table, int $id, $fields): bool
{
$table = $this->_prefix . $table;

return !$this->query("UPDATE {$table} SET {$field} = {$field} - 1 WHERE id = ?", [$id])->error();
if (!is_array($fields)) {
return !$this->query("UPDATE {$table} SET {$fields} = {$fields} - 1 WHERE id = ?", [$id])->error();
} else {
$set = '';
$x = 1;

foreach (array_keys($fields) as $column) {
$set .= "`{$column}` = `{$column}` - ?";
if ($x < count($fields)) {
$set .= ', ';
}
$x++;
}
}

$sql = "UPDATE {$table} SET {$set} WHERE id = ?";

return !$this->query($sql, array_merge($fields, [$id]))->error();
}

/**
Expand Down