Skip to content

SDR: HPRTU multi-spd obj to var-spd obj coil conversion #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanghyunJK wants to merge 6 commits into
base: main
Choose a base branch
from
+164 −133
Open

SDR: HPRTU multi-spd obj to var-spd obj coil conversion #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efeaa37
cooling coil obj conversion first draft
JanghyunJK Apr 18, 2025
4680ae8
heating coil obj conversion first draft + misc fix
JanghyunJK Apr 18, 2025
9b42846
unit test update for multi-to-var coil conversion
JanghyunJK Apr 19, 2025
24d93f7
revise upsizing airflow
JanghyunJK Apr 22, 2025
45b6a2e
revise unit test for multi to var spd coil conversion
JanghyunJK Apr 23, 2025
777b159
stage to speed for var spd coil obj
JanghyunJK Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion measures/comstock_sensitivity_reports/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ def get_heating_coil_capacity_and_cop(runner, model, coil)
temp_capacity_w = speed.referenceUnitGrossRatedHeatingCapacity

# get capacity and capacity at lower temperatures
cap_curve = stage.heatingCapacityFunctionofTemperatureCurve
cap_curve = speed.heatingCapacityFunctionofTemperatureCurve
if cap_curve.to_CurveCubic.is_initialized
coil_cap_17F = cap_curve.evaluate(OpenStudio.convert(17.0, 'F', 'C').get)
capacity_17F_w = capacity_w * coil_cap_17F if temp_capacity_w >= capacity_w
Expand Down
146 changes: 112 additions & 34 deletions resources/measures/upgrade_hvac_add_heat_pump_rtu/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,19 +680,39 @@ def set_cooling_coil_stages(model, runner, stage_flows_cooling, stage_caps_cooli
else

# define multi speed cooling coil
new_dx_cooling_coil = OpenStudio::Model::CoilCoolingDXMultiSpeed.new(model)
####################################################################################
# BEFORE
####################################################################################
# new_dx_cooling_coil = OpenStudio::Model::CoilCoolingDXMultiSpeed.new(model)
# new_dx_cooling_coil.setName("#{air_loop_hvac.name} Heat Pump Cooling Coil")
# new_dx_cooling_coil.setCondenserType('AirCooled')
# new_dx_cooling_coil.setAvailabilitySchedule(always_on) # NA
# new_dx_cooling_coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(-25)
# new_dx_cooling_coil.setApplyPartLoadFractiontoSpeedsGreaterthan1(enable_cycling_losses_above_lowest_speed) # NA
# new_dx_cooling_coil.setApplyLatentDegradationtoSpeedsGreaterthan1(false) # NA
# new_dx_cooling_coil.setFuelType('Electricity') # NA
# new_dx_cooling_coil.setMaximumOutdoorDryBulbTemperatureforCrankcaseHeaterOperation(4.4)
# # methods from "TECHNICAL SUPPORT DOCUMENT: ENERGY EFFICIENCY PROGRAM FOR CONSUMER PRODUCTS AND COMMERCIAL AND INDUSTRIAL EQUIPMENT AIR-COOLED COMMERCIAL UNITARY AIR CONDITIONERS AND COMMERCIAL UNITARY HEAT PUMPS"
# crankcase_heater_power = ((60 * (stage_caps_cooling[rated_stage_num_cooling] * 0.0002843451 / 10)**0.67))
# new_dx_cooling_coil.setCrankcaseHeaterCapacity(crankcase_heater_power)
# new_dx_cooling_coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(-25)
####################################################################################
# AFTER
####################################################################################
new_dx_cooling_coil = OpenStudio::Model::CoilCoolingDXVariableSpeed.new(model)
new_dx_cooling_coil.setName("#{air_loop_hvac.name} Heat Pump Cooling Coil")
new_dx_cooling_coil.setCondenserType('AirCooled')
new_dx_cooling_coil.setAvailabilitySchedule(always_on)
new_dx_cooling_coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(-25)
new_dx_cooling_coil.setApplyPartLoadFractiontoSpeedsGreaterthan1(enable_cycling_losses_above_lowest_speed)
new_dx_cooling_coil.setApplyLatentDegradationtoSpeedsGreaterthan1(false)
new_dx_cooling_coil.setFuelType('Electricity')
new_dx_cooling_coil.setMaximumOutdoorDryBulbTemperatureforCrankcaseHeaterOperation(4.4)
# methods from "TECHNICAL SUPPORT DOCUMENT: ENERGY EFFICIENCY PROGRAM FOR CONSUMER PRODUCTS AND COMMERCIAL AND INDUSTRIAL EQUIPMENT AIR-COOLED COMMERCIAL UNITARY AIR CONDITIONERS AND COMMERCIAL UNITARY HEAT PUMPS"
crankcase_heater_power = ((60 * (stage_caps_cooling[rated_stage_num_cooling] * 0.0002843451 / 10)**0.67))
new_dx_cooling_coil.setCrankcaseHeaterCapacity(crankcase_heater_power)
new_dx_cooling_coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(-25)
new_dx_cooling_coil.setNominalTimeforCondensatetoBeginLeavingtheCoil(1000)
new_dx_cooling_coil.setInitialMoistureEvaporationRateDividedbySteadyStateACLatentCapacity(1.5)
new_dx_cooling_coil.setLatentCapacityTimeConstant(45)
new_dx_cooling_coil.setEnergyPartLoadFractionCurve(cool_plf_fplr1)
# new_dx_cooling_coil.autosizeEvaporativeCondenserPumpRatedPowerConsumption # NA, not used when air-cooled

# loop through stages
stage_caps_cooling.sort.each do |stage, cap|
Expand All @@ -703,26 +723,44 @@ def set_cooling_coil_stages(model, runner, stage_flows_cooling, stage_caps_cooli
applied_stage = stage_caps_cooling.reject { |_k, v| v == false }.keys.min if cap == false

# add speed data for each stage
dx_coil_speed_data = OpenStudio::Model::CoilCoolingDXMultiSpeedStageData.new(model)
dx_coil_speed_data.setGrossRatedTotalCoolingCapacity(stage_caps_cooling[applied_stage])
dx_coil_speed_data.setGrossRatedSensibleHeatRatio(stage_gross_rated_sensible_heat_ratio_cooling[applied_stage])
dx_coil_speed_data.setRatedAirFlowRate(stage_flows_cooling[applied_stage])
dx_coil_speed_data.setGrossRatedCoolingCOP(final_rated_cooling_cop * stage_rated_cop_frac_cooling[applied_stage])
####################################################################################
# BEFORE
####################################################################################
# dx_coil_speed_data = OpenStudio::Model::CoilCoolingDXMultiSpeedStageData.new(model)
# dx_coil_speed_data.setGrossRatedTotalCoolingCapacity(stage_caps_cooling[applied_stage])
# dx_coil_speed_data.setGrossRatedSensibleHeatRatio(stage_gross_rated_sensible_heat_ratio_cooling[applied_stage])
# dx_coil_speed_data.setRatedAirFlowRate(stage_flows_cooling[applied_stage])
# dx_coil_speed_data.setGrossRatedCoolingCOP(final_rated_cooling_cop * stage_rated_cop_frac_cooling[applied_stage])
# dx_coil_speed_data.setRatedEvaporatorFanPowerPerVolumeFlowRate2017(773.3)
# dx_coil_speed_data.setTotalCoolingCapacityFunctionofTemperatureCurve(cool_cap_ft_curve_stages[applied_stage])
# dx_coil_speed_data.setTotalCoolingCapacityFunctionofFlowFractionCurve(cool_cap_ff_curve_stages[applied_stage])
# dx_coil_speed_data.setEnergyInputRatioFunctionofTemperatureCurve(cool_eir_ft_curve_stages[applied_stage])
# dx_coil_speed_data.setEnergyInputRatioFunctionofFlowFractionCurve(cool_eir_ff_curve_stages[applied_stage])
# dx_coil_speed_data.setPartLoadFractionCorrelationCurve(cool_plf_fplr1)
# dx_coil_speed_data.setEvaporativeCondenserEffectiveness(0.9)
# dx_coil_speed_data.setNominalTimeforCondensateRemovaltoBegin(1000)
# dx_coil_speed_data.setRatioofInitialMoistureEvaporationRateandSteadyStateLatentCapacity(1.5)
# dx_coil_speed_data.setLatentCapacityTimeConstant(45)
# dx_coil_speed_data.autosizeEvaporativeCondenserAirFlowRate
# dx_coil_speed_data.autosizeRatedEvaporativeCondenserPumpPowerConsumption
####################################################################################
# AFTER
####################################################################################
dx_coil_speed_data = OpenStudio::Model::CoilCoolingDXVariableSpeedSpeedData.new(model)
dx_coil_speed_data.setReferenceUnitGrossRatedTotalCoolingCapacity(stage_caps_cooling[applied_stage])
dx_coil_speed_data.setReferenceUnitGrossRatedSensibleHeatRatio(stage_gross_rated_sensible_heat_ratio_cooling[applied_stage])
dx_coil_speed_data.setReferenceUnitRatedAirFlowRate(stage_flows_cooling[applied_stage])
dx_coil_speed_data.setReferenceUnitGrossRatedCoolingCOP(final_rated_cooling_cop * stage_rated_cop_frac_cooling[applied_stage])
dx_coil_speed_data.setRatedEvaporatorFanPowerPerVolumeFlowRate2017(773.3)
dx_coil_speed_data.setTotalCoolingCapacityFunctionofTemperatureCurve(cool_cap_ft_curve_stages[applied_stage])
dx_coil_speed_data.setTotalCoolingCapacityFunctionofFlowFractionCurve(cool_cap_ff_curve_stages[applied_stage])
dx_coil_speed_data.setTotalCoolingCapacityFunctionofAirFlowFractionCurve(cool_cap_ff_curve_stages[applied_stage])
dx_coil_speed_data.setEnergyInputRatioFunctionofTemperatureCurve(cool_eir_ft_curve_stages[applied_stage])
dx_coil_speed_data.setEnergyInputRatioFunctionofFlowFractionCurve(cool_eir_ff_curve_stages[applied_stage])
dx_coil_speed_data.setPartLoadFractionCorrelationCurve(cool_plf_fplr1)
dx_coil_speed_data.setEvaporativeCondenserEffectiveness(0.9)
dx_coil_speed_data.setNominalTimeforCondensateRemovaltoBegin(1000)
dx_coil_speed_data.setRatioofInitialMoistureEvaporationRateandSteadyStateLatentCapacity(1.5)
dx_coil_speed_data.setLatentCapacityTimeConstant(45)
dx_coil_speed_data.autosizeEvaporativeCondenserAirFlowRate
dx_coil_speed_data.autosizeRatedEvaporativeCondenserPumpPowerConsumption
dx_coil_speed_data.setEnergyInputRatioFunctionofAirFlowFractionCurve(cool_eir_ff_curve_stages[applied_stage])
# dx_coil_speed_data.setEvaporativeCondenserEffectiveness(0.9) # NA
# dx_coil_speed_data.autosizeEvaporativeCondenserAirFlowRate # NA

# add speed data to multispeed coil object
new_dx_cooling_coil.addStage(dx_coil_speed_data) # unless stage_caps_heating[stage] == false
new_dx_cooling_coil.addSpeed(dx_coil_speed_data) # unless stage_caps_heating[stage] == false
end
end
new_dx_cooling_coil
Expand Down Expand Up @@ -776,7 +814,29 @@ def set_heating_coil_stages(model, runner, stage_flows_heating, stage_caps_heati
# use multi speed DX heating coil if multiple speeds are defined
else
# define multi speed heating coil
new_dx_heating_coil = OpenStudio::Model::CoilHeatingDXMultiSpeed.new(model)
####################################################################################
# BEFORE
####################################################################################
# new_dx_heating_coil = OpenStudio::Model::CoilHeatingDXMultiSpeed.new(model)
# new_dx_heating_coil.setName("#{air_loop_hvac.name} Heat Pump heating Coil")
# new_dx_heating_coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(OpenStudio.convert(hp_min_comp_lockout_temp_f, 'F', 'C').get)
# new_dx_heating_coil.setAvailabilitySchedule(always_on)
# new_dx_heating_coil.setApplyPartLoadFractiontoSpeedsGreaterthan1(enable_cycling_losses_above_lowest_speed)
# new_dx_heating_coil.setFuelType('Electricity')
# # methods from "TECHNICAL SUPPORT DOCUMENT: ENERGY EFFICIENCY PROGRAM FOR CONSUMER PRODUCTS AND COMMERCIAL AND INDUSTRIAL EQUIPMENT AIR-COOLED COMMERCIAL UNITARY AIR CONDITIONERS AND COMMERCIAL UNITARY HEAT PUMPS"
# crankcase_heater_power = ((60 * (stage_caps_heating[rated_stage_num_heating] * 0.0002843451 / 10)**0.67))
# new_dx_heating_coil.setCrankcaseHeaterCapacity(crankcase_heater_power)
# new_dx_heating_coil.setMaximumOutdoorDryBulbTemperatureforCrankcaseHeaterOperation(4.4)
# new_dx_heating_coil.setDefrostEnergyInputRatioFunctionofTemperatureCurve(defrost_eir)
# new_dx_heating_coil.setMaximumOutdoorDryBulbTemperatureforDefrostOperation(4.444)
# new_dx_heating_coil.setDefrostStrategy('ReverseCycle')
# new_dx_heating_coil.setDefrostControl('OnDemand')
# new_dx_heating_coil.setDefrostTimePeriodFraction(0.058333)
# new_dx_heating_coil.setFuelType('Electricity')
####################################################################################
# AFTER
####################################################################################
new_dx_heating_coil = OpenStudio::Model::CoilHeatingDXVariableSpeed .new(model)
new_dx_heating_coil.setName("#{air_loop_hvac.name} Heat Pump heating Coil")
new_dx_heating_coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(OpenStudio.convert(
hp_min_comp_lockout_temp_f, 'F', 'C'
Expand All @@ -793,7 +853,8 @@ def set_heating_coil_stages(model, runner, stage_flows_heating, stage_caps_heati
new_dx_heating_coil.setDefrostStrategy('ReverseCycle')
new_dx_heating_coil.setDefrostControl('OnDemand')
new_dx_heating_coil.setDefrostTimePeriodFraction(0.058333)
new_dx_heating_coil.setFuelType('Electricity')
# new_dx_heating_coil.setFuelType('Electricity') # NA
new_dx_heating_coil.setEnergyPartLoadFractionCurve(heat_plf_fplr1)

# loop through stages
stage_caps_heating.sort.each do |stage, cap|
Expand All @@ -805,20 +866,37 @@ def set_heating_coil_stages(model, runner, stage_flows_heating, stage_caps_heati
applied_stage = stage_caps_heating.reject { |_k, v| v == false }.keys.min if cap == false

# add speed data for each stage
dx_coil_speed_data = OpenStudio::Model::CoilHeatingDXMultiSpeedStageData.new(model)
dx_coil_speed_data.setGrossRatedHeatingCapacity(stage_caps_heating[applied_stage])
dx_coil_speed_data.setGrossRatedHeatingCOP(final_rated_heating_cop * _stage_rated_cop_frac_heating[applied_stage])
dx_coil_speed_data.setRatedAirFlowRate(stage_flows_heating[applied_stage])
dx_coil_speed_data.setRatedSupplyAirFanPowerPerVolumeFlowRate2017(773.3)
dx_coil_speed_data.setHeatingCapacityFunctionofTemperatureCurve(heat_cap_ft_curve_stages[applied_stage])
####################################################################################
# BEFORE
####################################################################################
# dx_coil_speed_data = OpenStudio::Model::CoilHeatingDXMultiSpeedStageData.new(model)
# dx_coil_speed_data.setGrossRatedHeatingCapacity(stage_caps_heating[applied_stage])
# dx_coil_speed_data.setGrossRatedHeatingCOP(final_rated_heating_cop * _stage_rated_cop_frac_heating[applied_stage])
# dx_coil_speed_data.setRatedAirFlowRate(stage_flows_heating[applied_stage])
# dx_coil_speed_data.setRatedSupplyAirFanPowerPerVolumeFlowRate2017(773.3)
# dx_coil_speed_data.setHeatingCapacityFunctionofTemperatureCurve(heat_cap_ft_curve_stages[applied_stage])
# # set performance curves
# dx_coil_speed_data.setHeatingCapacityFunctionofTemperatureCurve(heat_cap_ft_curve_stages[applied_stage])
# dx_coil_speed_data.setHeatingCapacityFunctionofFlowFractionCurve(heat_cap_ff_curve_stages[applied_stage])
# dx_coil_speed_data.setEnergyInputRatioFunctionofTemperatureCurve(heat_eir_ft_curve_stages[applied_stage])
# dx_coil_speed_data.setEnergyInputRatioFunctionofFlowFractionCurve(heat_eir_ff_curve_stages[applied_stage])
# dx_coil_speed_data.setPartLoadFractionCorrelationCurve(heat_plf_fplr1)
####################################################################################
# AFTER
####################################################################################
dx_coil_speed_data = OpenStudio::Model::CoilHeatingDXVariableSpeedSpeedData.new(model)
dx_coil_speed_data.setReferenceUnitGrossRatedHeatingCapacity(stage_caps_heating[applied_stage])
dx_coil_speed_data.setReferenceUnitGrossRatedHeatingCOP(final_rated_heating_cop * _stage_rated_cop_frac_heating[applied_stage])
dx_coil_speed_data.setReferenceUnitRatedAirFlowRate(stage_flows_heating[applied_stage])
dx_coil_speed_data.setRatedSupplyFanPowerPerVolumeFlowRate2017(773.3)
# set performance curves
dx_coil_speed_data.setHeatingCapacityFunctionofTemperatureCurve(heat_cap_ft_curve_stages[applied_stage])
dx_coil_speed_data.setHeatingCapacityFunctionofFlowFractionCurve(heat_cap_ff_curve_stages[applied_stage])
dx_coil_speed_data.setTotalHeatingCapacityFunctionofAirFlowFractionCurve(heat_cap_ff_curve_stages[applied_stage])
dx_coil_speed_data.setEnergyInputRatioFunctionofTemperatureCurve(heat_eir_ft_curve_stages[applied_stage])
dx_coil_speed_data.setEnergyInputRatioFunctionofFlowFractionCurve(heat_eir_ff_curve_stages[applied_stage])
dx_coil_speed_data.setPartLoadFractionCorrelationCurve(heat_plf_fplr1)
dx_coil_speed_data.setEnergyInputRatioFunctionofAirFlowFractionCurve(heat_eir_ff_curve_stages[applied_stage])

# add speed data to multispeed coil object
new_dx_heating_coil.addStage(dx_coil_speed_data) # falseunless stage_caps_cooling[stage] == false # temporary 'unless' until bug fix for (https://github.com/NREL/OpenStudio/issues/5277)
new_dx_heating_coil.addSpeed(dx_coil_speed_data) # falseunless stage_caps_cooling[stage] == false # temporary 'unless' until bug fix for (https://github.com/NREL/OpenStudio/issues/5277)
end
end
new_dx_heating_coil
Expand Down Expand Up @@ -2159,8 +2237,8 @@ def run(model, runner, user_arguments)
upsize_factor = (dx_rated_htg_cap_applied - orig_clg_coil_gross_cap) / orig_clg_coil_gross_cap

# upsize airflow accordingly
# design_heating_airflow_m_3_per_s *= (1 + upsize_factor)
# design_cooling_airflow_m_3_per_s *= (1 + upsize_factor)
design_heating_airflow_m_3_per_s *= (1 + upsize_factor)
design_cooling_airflow_m_3_per_s *= (1 + upsize_factor)

if debug_verbose
runner.registerInfo('sizing summary: before rated cfm/ton adjustmant')
Expand Down
Loading