Skip to content

SDR: HPRTU measure: setting fan max flow the same as coil rated flow #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanghyunJK wants to merge 4 commits into
base: main
Choose a base branch
from
+106 −80
Open

SDR: HPRTU measure: setting fan max flow the same as coil rated flow #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e2461e
setting max flow fan the same as coil airflow
JanghyunJK May 20, 2025
c0f3940
adding unit test to check fan flow + rubocop
JanghyunJK May 20, 2025
4ffef0e
Update measure.xml
JanghyunJK May 20, 2025
74f455e
Update resources/measures/upgrade_hvac_add_heat_pump_rtu/measure.rb
JanghyunJK Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions resources/measures/upgrade_hvac_add_heat_pump_rtu/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2406,6 +2406,11 @@ def run(model, runner, user_arguments)
new_fan.setName("#{air_loop_hvac.name} VFD Fan")
new_fan.setMotorEfficiency(fan_mot_eff) # from Daikin Rebel E+ file
new_fan.setFanPowerMinimumFlowRateInputMethod('Fraction')
fan_max_flow = stage_flows_cooling[num_cooling_stages]
if stage_flows_heating[num_heating_stages] > stage_flows_cooling[num_cooling_stages]
fan_max_flow = stage_flows_heating[num_heating_stages]
end
new_fan.setMaximumFlowRate(fan_max_flow)

# set fan total efficiency, which determines fan power
if hprtu_scenario == 'variable_speed_high_eff'
Expand Down
8 changes: 4 additions & 4 deletions resources/measures/upgrade_hvac_add_heat_pump_rtu/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>add_heat_pump_rtu</name>
<uid>f4567a68-27f2-4a15-ae91-ba0f35cd08c7</uid>
<version_id>6b6f4c1d-cf0b-4ea1-b3fd-0089a59f56ea</version_id>
<version_modified>2025-07-23T23:00:34Z</version_modified>
<version_id>971c6c78-c0ed-46c3-bcb0-f8f324e58a4b</version_id>
<version_modified>2025-05-20T21:19:15Z</version_modified>
<xml_checksum>5E2576E4</xml_checksum>
<class_name>AddHeatPumpRtu</class_name>
<display_name>add_heat_pump_rtu</display_name>
Expand Down Expand Up @@ -341,7 +341,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>F4B40836</checksum>
<checksum>B25E5633</checksum>
</file>
<file>
<filename>call_other_measures.rb</filename>
Expand Down Expand Up @@ -389,7 +389,7 @@
<filename>measure_test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>8E751853</checksum>
<checksum>27A9A796</checksum>
</file>
</files>
</measure>
Loading