-
Notifications
You must be signed in to change notification settings - Fork 27
Docs: Convert notebooks to scripts and executable markdown #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Convert notebooks to scripts and executable markdown #464
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
johnjasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, Rob! It's nice to see impactful improvements for docs and their maintainability, especially as H2I is ramping up in maturity.
I pushed some updates to use more literalincludes where appropriate; I really like that. Good to come in from my end, I'll merge once tests pass!
| ```{literalinclude} ../../examples/14_wind_hydrogen_dispatch/inputs/tech_config.yaml | ||
| :language: yaml | ||
| :lineno-start: 54 | ||
| :linenos: true | ||
| :lines: 54,59-61,67-74 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aw yeah, this is the secret sauce that will help us avoid defunct yaml depictions in the docs! Love it, will highlight in the standup.
Convert the Jupyter Notebooks to Documentation Examples and Python Scripts for Better Docs and Diffs
This PR focuses on replacing all Jupyter notebooks in the
examples/anddocs/directories with simplified Python scripts and executable notebooks providing in depth demonstrations, respectively.Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.mdhas been updated to describe the changes made in this PRSection 3: Related Issues
This will resolve #75
Section 4: Impacted Areas of the Software
Section 4.1: New Files
docs/control/controller_demonstrations.md: replaces the oldexamples/14_wind_hydrogen_dispatch/hydrogren_dispatch.ipynbexamples/14_wind_hydrogen_dispatch/hydrogren_dispatch.py: simplified version ofexamples/14_wind_hydrogen_dispatch/hydrogren_dispatch.ipynbdocs/user_guide/design_of_experiments_in_h2i.mdnow includes the detailed demonstration fromexamples/20_solar_electrolyzer_doe/run_csv_doe.ipynbexamples/20_solar_electrolyzer_doe/run_csv_doe.pyis a pared down version ofexamples/20_solar_electrolyzer_doe/run_csv_doe.ipynbdocs/user_guide/run_size_modes.md: replacesexamples/25_sizing_modes/run_size_modes.ipynband fixes bugsexamples/25_sizing_modes/run_size_modes.py: simplified form ofexamples/25_sizing_modes/run_size_modes.ipynbdocs/misc_resources/turbine_models_library_preprocessing.md: replacesdocs/user_guide/how_to_set_up_an_analysis.ipynb, and fixes broken functionality with minor formatting cleanup.docs/user_guide/how_to_set_up_an_analysis.md: replacesdocs/user_guide/how_to_set_up_an_analysis.ipynbSection 4.2: Modified Files
.gitignore: Includes more example output data files and folders.docs/_config.yml: ensures executable content doesn't get wrapped up in the many autosummary warnings, and raises a build errordocs/_toc.yml: updated to reflect the new or modified file references.Section 5: Additional Supporting Information
See the discussion in #75 for further details.
Section 6: Test Results, if applicable
N/A
Section 7 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pycreate_financial_modelinh2integrate_model.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.yml