Fix expanded roof types in hvac sizing#2157
Merged
Conversation
Collaborator
Author
|
Implemented mapping based on Manual J A12-14 and A12-16: |
Collaborator
Author
|
Wall sidings are also investigated, ManualJ 4A only has two categories for wall exterior finish: stucco or siding vs brick, so I think there's nothing to change in the current implementation |
shorowit
approved these changes
Feb 3, 2026
Contributor
shorowit
left a comment
There was a problem hiding this comment.
Looks good! I added one more safety check, this can merge in if the CI is still happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Some roof types are not included in the hvac sizing, which will cause suspicious design temperatures for attics.
PR to expand roof types and wall sidings: #804
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run