Skip to content

Fix expanded roof types in hvac sizing#2157

Merged
shorowit merged 4 commits intomasterfrom
roof_type_in_sizing
Feb 3, 2026
Merged

Fix expanded roof types in hvac sizing#2157
shorowit merged 4 commits intomasterfrom
roof_type_in_sizing

Conversation

@yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Jan 30, 2026

Pull Request Description

Some roof types are not included in the hvac sizing, which will cause suspicious design temperatures for attics.
PR to expand roof types and wall sidings: #804

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@yzhou601
Copy link
Collaborator Author

Implemented mapping based on Manual J A12-14 and A12-16:
ManualJ_RoofTypes.xlsx

@yzhou601
Copy link
Collaborator Author

Wall sidings are also investigated, ManualJ 4A only has two categories for wall exterior finish: stucco or siding vs brick, so I think there's nothing to change in the current implementation

@yzhou601 yzhou601 requested a review from shorowit January 30, 2026 21:10
@yzhou601 yzhou601 marked this pull request as ready for review February 2, 2026 20:07
@shorowit shorowit moved this from Triage to In progress in OpenStudio-HPXML Feb 3, 2026
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added one more safety check, this can merge in if the CI is still happy.

@shorowit shorowit merged commit 3bbf623 into master Feb 3, 2026
7 checks passed
@shorowit shorowit deleted the roof_type_in_sizing branch February 3, 2026 20:58
@github-project-automation github-project-automation bot moved this from In progress to Done in OpenStudio-HPXML Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants