#1697 - Re-wrap Thermochromic window model properly to handle extensible fields and translation to/from EnergyPlus

[jmarrec]

Pull request overview

• Fixes Re-wrap Thermochromic window model properly #1697

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: #1697 - Add a Ruby and Python tests for ThermochromicGlazing OpenStudio-resources#221
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp): Don't think it's needed
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for 1191f7e:

• Ubuntu 24.04:

  • OpenStudio-3.10.0-rc1+1191f7e597-Ubuntu-24.04-x86_64.deb
  • OpenStudio-3.10.0-rc1+1191f7e597-Ubuntu-24.04-x86_64.tar.gz

• Ubuntu 22.04:

  • OpenStudio-3.10.0-rc1+1191f7e597-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.10.0-rc1+1191f7e597-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

• Windows:

  • OpenStudio-3.10.0-rc1+1191f7e597-Windows.exe
  • OpenStudio-3.10.0-rc1+1191f7e597-Windows.tar.gz

• Code Coverage:

[jmarrec]

@anchapin did you merge this by mistake? It has a failing cppcheck and Joe didn't have time to review it.

[anchapin]

@jmarrec sorry for that. I asked @tijcolem and he suggested to merge it.