Add module-level R_GAS constant value to diffusion.py#313
Merged
RDaxini merged 4 commits intodevelopmentfrom Feb 4, 2026
Merged
Add module-level R_GAS constant value to diffusion.py#313RDaxini merged 4 commits intodevelopmentfrom
diffusion.py#313RDaxini merged 4 commits intodevelopmentfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #313 +/- ##
===============================================
+ Coverage 71.66% 74.72% +3.06%
===============================================
Files 40 41 +1
Lines 4524 4823 +299
===============================================
+ Hits 3242 3604 +362
+ Misses 1282 1219 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martin-springer
approved these changes
Feb 4, 2026
Collaborator
martin-springer
left a comment
There was a problem hiding this comment.
lgtm! thanks for cleaning this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Replace hard-coded magic number
0.0083144626with a module-levelR_GAS(gas constant) valueIssue ticket number and link
Fixes # (issue)Type of change
Please delete options that are not relevant.
Checklist before requesting a review