Skip to content

Conversation

@RDaxini
Copy link
Collaborator

@RDaxini RDaxini commented Jan 26, 2026

Describe your changes

Fix failing pytests and nbval/testbook checks.

Fixes include:

  • psm3 calls, e.g to read local psm3 files, manual read_csv function is used now rather than the pvlib read psm3 function that was removed in the latest v0.14.0 release. Note: docs updated
  • "H" -> "h"
  • units formatting in the o2permeation database, causing some of the tests in test_utilities.py to fail
  • material format handling
  • use .iloc[0] for positional indexing in humidity tests
  • convert strings to objects in convert_tmy
  • rerun notebooks

Issue ticket number and link

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@RDaxini RDaxini added bug Something isn't working enhancement New feature or request api Pull requests that update the core functions and classes testing labels Jan 26, 2026
@RDaxini RDaxini added this to the v0.7.1 milestone Jan 26, 2026
@RDaxini RDaxini changed the title Fix tests: psm3-related functions, utilities.py Fixes for pandas 3.0.0 and pvlib 0.14.0 Jan 26, 2026
@RDaxini RDaxini mentioned this pull request Jan 26, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (51172fd) to head (e50f2ad).
⚠️ Report is 428 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #314      +/-   ##
===============================================
+ Coverage        71.66%   74.72%   +3.05%     
===============================================
  Files               40       41       +1     
  Lines             4524     4822     +298     
===============================================
+ Hits              3242     3603     +361     
+ Misses            1282     1219      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RDaxini RDaxini changed the base branch from main to development February 2, 2026 23:07
Co-authored-by: Martin Springer <97482055+martin-springer@users.noreply.github.com>
@RDaxini RDaxini merged commit c3fdc4b into development Feb 3, 2026
18 checks passed
@RDaxini RDaxini deleted the psm3 branch February 3, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Pull requests that update the core functions and classes bug Something isn't working enhancement New feature or request testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants