Fix URLSearchParams.forEach() crash and spec compliance #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use v8::Undefined(isolate) instead of empty v8::Local<v8::Value>() - Changed argument order from (key, value) to (value, key, searchParams) - Use get_entries() iterator instead of get_keys() + get() for duplicate keys - Support the optional thisArg second parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
URLSearchParams.forEach()to match the spec.Equivalent fix for Android: NativeScript/android#1895
Problem
Calling
url.searchParams.forEach()in NativeScript iOS crashed withEXC_BAD_ACCESS (code=1, address=0x0)because an emptyv8::Local<v8::Value>()was passed as thethisArgtocallback->Call().Fixes
v8::Undefined(isolate)instead of emptyv8::Local<v8::Value>()(key, value)to(value, key, searchParams)get_entries()iterator instead ofget_keys()+get()Changes
NativeScript/runtime/URLSearchParamsImpl.cppTestRunner/app/tests/URLSearchParams.jsKnown Limitations (pre-existing)
The
entries()andvalues()methods still useget_keys()+get()which doesn't handle duplicate keys correctly.