fix: Change hash encoding, support passing in code without borsh
#152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@r-near can you please bump the rust in seperate PR, because probably this PR will be cherry picked |
r-near
changed the title
code without borsh
Contributor
Author
|
Closes #150 |
karim-en
requested changes
Feb 26, 2025
karim-en
requested changes
Feb 26, 2025
karim-en
approved these changes
Feb 26, 2025
frolvanya
approved these changes
Feb 26, 2025
karim-en
approved these changes
Mar 1, 2025
olga24912
reviewed
Mar 3, 2025
| .try_into() | ||
| .expect("Code should be converted to CryptoHash") | ||
| /// Converts code to a base58-encoded CryptoHash string. | ||
| fn convert_code_to_crypto_hash(code: &[u8]) -> String { |
Contributor
There was a problem hiding this comment.
This is not crypto_hash; right now, we are returning CryptoHash. It's not very important, but maybe we could rename it to convert_code_to_bs58_encoded_hash or something like that?
olga24912
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up_staged_code_hash()return type fromOption<CryptoHash>toOption<String>and updates all hash generation/comparison code accordinglycodedirectly instead of with BorshCloses #150