Fix a tag stocking input bus crash with invalid syntax in one of the fields#25
Merged
NegaNote merged 3 commits intoNegaNote:mainfrom Feb 8, 2026
Merged
Conversation
NegaNote
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if invalid syntax is entered in the tag stocking input bus, and any item appears in the ME network that looks like it could match the expression, the server crashes:
crash-2026-02-07_16.18.40-server.txt
Curiously, the following syntax
forge:dusts/(redstone|iron), which works for Tag Storage Bus, is invalid, because it is tokenized as["forge:dusts/", "(", "redstone", "|", "iron", ")"]and parsed as["forge:dusts/", "redstone", "iron", Operator(OR)], which leaves the stack interpreter at depth of 2.This PR fixes the server crash, and also makes it so invalid syntax is clearly displayed in the bus UI.