Rename dense_poly_type to poly_type
#2202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2202 +/- ##
=======================================
Coverage 87.95% 87.95%
=======================================
Files 127 127
Lines 31773 31773
=======================================
Hits 27947 27947
Misses 3826 3826 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
reviewed
Oct 30, 2025
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
There is also dense_poly_ring_type that should be renamed analogously.
src/Aliases.jl
Outdated
| @alias nrows number_of_rows | ||
| @alias nvars number_of_variables | ||
|
|
||
| # TEMPORARY HACK -- delete after Nemo & Hecke have been updated |
Member
There was a problem hiding this comment.
We have a dedicated section for these kinds of aliases in
, please put this there. In that file, you also shouldn't need thefunction poly_type end anymore
lgoettgens
changed the title
dense_poly_type to poly_type
lgoettgens
reviewed
Oct 31, 2025
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Collaborator
Author
OK, I can do that too. I saw it, and meant to ask... then forgot about it! |
…Algebra.jl into JAA/dense_poly_type
lgoettgens
reviewed
Oct 31, 2025
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
lgoettgens
approved these changes
Nov 3, 2025
lgoettgens
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1301.
Fairly mindless global string substitution. Do I need to create an alias in
src/aliases.jl?