Merge characteristic docstrings
#2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2271 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 126 126
Lines 31804 31804
=======================================
Hits 28090 28090
Misses 3714 3714 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is part of the general ring interface, so no need to mention this everywhere.
lgoettgens
reviewed
Jan 4, 2026
| Return the characteristic of the ring `R`. If the characteristic | ||
| is not known, an exception is raised. | ||
| """ |
Member
There was a problem hiding this comment.
This new docstring should be included in the docs somewhere
Member
Author
There was a problem hiding this comment.
IIRC it already is, but I'll double check tomorrow
lgoettgens
changed the title
characteristic docstrings
lgoettgens
approved these changes
Jan 7, 2026
|
|
||
| ```julia | ||
| ```@docs | ||
| characteristic(R::NCRing) |
Member
There was a problem hiding this comment.
I have overseen this. Here, we add the docstring. So this resolves my other comment
lgoettgens
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from PR #2270