Open
Conversation
Member
Agreed
Agreed
Agreed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2228 +/- ##
==========================================
- Coverage 88.35% 88.34% -0.01%
==========================================
Files 100 100
Lines 37245 37237 -8
==========================================
- Hits 32906 32896 -10
- Misses 4339 4341 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Agreed. |
This really should have been a 'roots' method. But in fact it does nothing that's special to ZZRingElem, so the generic roots method should just handle this.
fingolfin
force-pushed
the
mh/remove-zeros
branch
from
d25faa7 to
683acf0
Compare
This was referenced Feb 19, 2026
lgoettgens
approved these changes
Feb 23, 2026
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
Hecke master is now happy with this change, so I would be happy to add this to the next breaking release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This really should have been a 'roots' method. But in fact it does nothing that's special to ZZRingElem, so the generic roots method should just handle this. But it didn't, until Nemocas/AbstractAlgebra.jl#2292 -- thus perhaps this PR should only be merged once we released AA 0.48.2, then this PR could change our AA compat to
>= 0.48.2This is technically breaking, but it really was a wrong method for
zeros, so I'd consider it more of a bug fix (but I'll concede it is a gray area). Alas I suspect it was there for a reason, i.e. someone (Hecke?) is probably using it). So probably best to wait with merging this till this until upstream CI passes again. Therefore marking this as a draft.