Skip to content

comment out unused health variable#5

Open
PlNG wants to merge 1 commit intoNerdNu:masterfrom
PlNG:patch-1
Open

comment out unused health variable#5
PlNG wants to merge 1 commit intoNerdNu:masterfrom
PlNG:patch-1

Conversation

@PlNG
Copy link

@PlNG PlNG commented Jun 14, 2021

Code review

@totemo
Copy link
Member

totemo commented Jun 14, 2021

That's scarcely an improvement. Chunks of commented out dead code wouldn't pass muster in many code review processes. Keeping them around is what the VCS is for. In this case, the dead code is trivial and at best the comment reflects some nebulous future intent to do something (maybe) in the future with it. We'd have to cut open dumbo's head and analyse it carefully to know.

In other words, deleting the line would be better.

Was there nothing else wrong with it all? I don't want to have to look at a series of PRs on this. Gather up all the code quality changes in on big PR please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants