Conversation
Member
|
That's scarcely an improvement. Chunks of commented out dead code wouldn't pass muster in many code review processes. Keeping them around is what the VCS is for. In this case, the dead code is trivial and at best the comment reflects some nebulous future intent to do something (maybe) in the future with it. We'd have to cut open dumbo's head and analyse it carefully to know. In other words, deleting the line would be better. Was there nothing else wrong with it all? I don't want to have to look at a series of PRs on this. Gather up all the code quality changes in on big PR please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review