[Issue 1593] Add support for AWS SDK v2#1597
Open
ChristopherHahnTR wants to merge 5 commits intoNetflix:2.xfrom
Open
[Issue 1593] Add support for AWS SDK v2#1597ChristopherHahnTR wants to merge 5 commits intoNetflix:2.xfrom
ChristopherHahnTR wants to merge 5 commits intoNetflix:2.xfrom
Conversation
spencergibb
suggested changes
May 30, 2025
Contributor
spencergibb
left a comment
spencergibb
left a comment
There was a problem hiding this comment.
Rather than if statements, create a AwsBinderDelegateV2 so there isn't a binary dependency on the V2 AWS API
eureka-core/src/main/java/com/netflix/eureka/aws/AwsBinderDelegate.java
Outdated
Show resolved
Hide resolved
ChristopherHahnTR
changed the title
spencergibb
reviewed
Jun 2, 2025
| eurekaServerHttpClientFactory | ||
| ); | ||
| awsBinder = new AwsBinderDelegate(eurekaServerConfig, eurekaClient.getEurekaClientConfig(), registry, applicationInfoManager); | ||
| if(eurekaServerConfig.isUseAwsSdkV2()) { |
Contributor
There was a problem hiding this comment.
This works for Spring Cloud since it does not use EurekaBootStrap
spencergibb
reviewed
Jun 2, 2025
| * | ||
| * @return | ||
| */ | ||
| default boolean isUseAwsSdkV2() { |
Contributor
There was a problem hiding this comment.
a default of false is great.
spencergibb
approved these changes
Jun 2, 2025
Contributor
spencergibb
left a comment
spencergibb
left a comment
There was a problem hiding this comment.
I have not reviewed any of the *V2 implementations, but the bit in EurekaBootStrap and EurekaServerConfig look fine for Spring Cloud Netflix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for AWS SDK v2. AWS SDK v1 is enabled by default, but the new SDK will be used by setting the config useAwsSdkV2=true
The new AWS classes handle region differently than the old.
Old behavior was to check if region is us-east-1 (default) and then override the endpoint URI for each service if it was different.
New code always sets the region based on region from configuration file, unless that value is blank.