Fix: differentiate ADDED and MODIFIED instance actions (#1602)#1604
Open
souvikree wants to merge 1 commit intoNetflix:masterfrom
Open
Fix: differentiate ADDED and MODIFIED instance actions (#1602)#1604souvikree wants to merge 1 commit intoNetflix:masterfrom
souvikree wants to merge 1 commit intoNetflix:masterfrom
Conversation
Author
|
I have submitted a PR (#1604) that fixes this issue by differentiating between ADDED and MODIFIED actions in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Issue #1602 where the
ADDEDandMODIFIEDactions in Eureka delta updates performed the same logic.Problem
Both
ADDEDandMODIFIEDwere callingaddInstance(), which made them behave identically. Because of this, Eureka couldn’t properly tell the difference between a new instance being registered and an existing instance being updated.Changes Made
DiscoveryClient.javasoMODIFIEDnow updates the existing instance instead of re-adding it.Result
With this change, It can now correctly distinguish between newly added instances and modified ones during delta processing.
Tested by building successfully on JDK 8 and verifying no compile or integration issues.