fix(config): correct GetDefault return type#10687
Merged
LukaszRozmej merged 4 commits intoNethermindEth:masterfrom Mar 3, 2026
Merged
fix(config): correct GetDefault return type#10687LukaszRozmej merged 4 commits intoNethermindEth:masterfrom
LukaszRozmej merged 4 commits intoNethermindEth:masterfrom
Conversation
Member
|
please add some test |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ConfigSourceHelper.GetDefault(Type) to return only the default value (as object) rather than a (false, value) tuple, preventing accidental nested tuples in config sources that already return (IsSet, Value).
Changes:
- Update
ConfigSourceHelper.GetDefault(Type)to returndefault(T)for value types andnullfor reference types.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LukaszRozmej
approved these changes
Mar 2, 2026
Contributor
Author
|
@LukaszRozmej fixed old test - it expected the buggy nested tuple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetDefault was returning a tuple (false, value) instead of just the value. This caused nested tuples when used in places like EnvConfigSource and ArgsConfigSource, where the result was already wrapped in (isSet, value).