Skip to content

test: Integration tests for client to daemon#290

Open
damonhayhurst-neuraco wants to merge 1 commit intondd-devfrom
feat/client-sdk-to-daemon-tests
Open

test: Integration tests for client to daemon#290
damonhayhurst-neuraco wants to merge 1 commit intondd-devfrom
feat/client-sdk-to-daemon-tests

Conversation

@damonhayhurst-neuraco
Copy link

@damonhayhurst-neuraco damonhayhurst-neuraco commented Jan 23, 2026

Features

  • Integration test for initalising the client sdk for data daemon communication
  • Client to socket tests also for testing serialisation

Copy link
Contributor

@StevenJacobs61 StevenJacobs61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a pattern of not using single letter or short abbreviations. We also don't leave man comments in the code, unless they are truly necessary, and in the case that the code needs comments, it is often the case that the code is not clear enough and needs rewriting

@damonhayhurst-neuraco damonhayhurst-neuraco force-pushed the feat/client-sdk-to-daemon-tests branch 2 times, most recently from 496f36d to 3f74fd2 Compare January 26, 2026 12:59
@damonhayhurst-neuraco damonhayhurst-neuraco changed the title feat: Integration tests for client to socket comms feat: Integration tests for client to daemon Jan 26, 2026
@damonhayhurst-neuraco damonhayhurst-neuraco force-pushed the feat/client-sdk-to-daemon-tests branch from 3f74fd2 to 585eb4e Compare January 26, 2026 15:39
@damonhayhurst-neuraco damonhayhurst-neuraco changed the title feat: Integration tests for client to daemon test: Integration tests for client to daemon Jan 26, 2026
Copy link
Contributor

@StevenJacobs61 StevenJacobs61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damonhayhurst-neuraco damonhayhurst-neuraco force-pushed the feat/client-sdk-to-daemon-tests branch from be8da91 to 1e6e4a2 Compare January 27, 2026 09:52
@damonhayhurst-neuraco damonhayhurst-neuraco force-pushed the feat/client-sdk-to-daemon-tests branch from 1e6e4a2 to 27d1b85 Compare January 27, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants