Skip to content

fix: ensure channel state#346

Open
StevenJacobs61 wants to merge 1 commit intondd-devfrom
fix/ensure-channel-state
Open

fix: ensure channel state#346
StevenJacobs61 wants to merge 1 commit intondd-devfrom
fix/ensure-channel-state

Conversation

@StevenJacobs61
Copy link
Contributor

Features

  • Implemented channel cleanup.
  • If channel a no ring buffer for a certain period it gets removed
  • If a channel gets data once it is closed it rejects it.

Bugfixes

  • Channels could become stake without closing or being cleaned up

@StevenJacobs61 StevenJacobs61 changed the base branch from main to ndd-dev February 2, 2026 17:32
muneebneura

This comment was marked as duplicate.

@muneebneura muneebneura self-requested a review February 2, 2026 18:12
Copy link
Contributor

@muneebneura muneebneura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure data collection runs fine with this, currently I can see lots of warnings coming from this:

 logger.warning(
                "Ignoring command %s from closed producer_id=%s",
                cmd,
                producer_id,
            )

@StevenJacobs61 StevenJacobs61 force-pushed the fix/ensure-channel-state branch 3 times, most recently from 9528937 to 1568a2f Compare February 4, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants