Skip to content

feat: add nyu franka play#353

Merged
sdas-neuraco merged 2 commits intomainfrom
feat--nyu-franka-play
Feb 5, 2026
Merged

feat: add nyu franka play#353
sdas-neuraco merged 2 commits intomainfrom
feat--nyu-franka-play

Conversation

@sdas-neuraco
Copy link
Contributor

Features

  • NYU Franka Play

Missing gripper values so the gripper visualization does not work.

@sdas-neuraco sdas-neuraco self-assigned this Feb 3, 2026
@sdas-neuraco sdas-neuraco added the version:patch non-breaking bug fixes; no input/output changes (except defaults) label Feb 3, 2026
Copy link
Contributor

@ypang-neuraco ypang-neuraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM \w comments

name: NYU_franka_play
tags: [unitree, humanoid, folding, clothes, manipulation]
tags: [franka, kitchen, play, cooking, manipulation]
description: "This dataset contains images and sensor data collected from the LeRobot Unitree H1 robot while performing fold clothes tasks in an indoor environment."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the description

Comment on lines 46 to 55
- name: panda_joint8
index: 7
- name: panda_hand_joint
index: 7
- name: panda_hand_tcp_joint
index: 7
- name: panda_finger_joint1
index: 7
- name: panda_finger_joint2
index: 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be visual joints?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dataset works out the box with the URDF so is it necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no gripper data at all so not sure how to proceed? as there is no way to hook up the grippers?

Copy link
Contributor

@ypang-neuraco ypang-neuraco Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unless we want to train on the finger joint values, its better to put it in visual joints.
You can leave visual_joint_type empty which will default to "CUSTOM" and you can log them like how you log joint positions.

On another note, perhaps we need functionality to go from joint position to gripper open amount in a separate PR.

from robot.py:

    def gripper_open_width_to_open_amount(
        self, gripper_open_width: float, gripper_joint_names: list[str]
    ) -> float:
        """Convert gripper joint positions to open amount.

        Args:
            gripper_joint_names: List of gripper joint names
            gripper_joint_positions: Dictionary mapping gripper
                joint names to position values

        Returns:
            Amount to open gripper (0-1)
        """
        joint_name = gripper_joint_names[0]  # Assume joints are symmetric
        min_pos, max_pos = self.joint_limits[joint_name]
        joint_pos = np.clip(gripper_open_width / 2.0, min_pos, max_pos)
        assert min_pos <= joint_pos <= max_pos, "Gripper joint position out of range"
        open_amount = (joint_pos - min_pos) / (max_pos - min_pos)
        assert 0.0 <= open_amount <= 1.0, "Gripper open amount out of range"
        return open_amount

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed we should make this a seperate PR would be good to have

@sdas-neuraco sdas-neuraco force-pushed the feat--nyu-franka-play branch from 82ece5b to d3c89d8 Compare February 4, 2026 16:31
@sdas-neuraco sdas-neuraco merged commit 726cf3b into main Feb 5, 2026
7 checks passed
@sdas-neuraco sdas-neuraco deleted the feat--nyu-franka-play branch February 5, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch non-breaking bug fixes; no input/output changes (except defaults)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants